Skip to content

chore(typescript-estree): migrate from jest to vitest #10679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Apr 14, 2025
Merged

chore(typescript-estree): migrate from jest to vitest #10679

merged 63 commits into from
Apr 14, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 18, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d043fbe
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fd10a9ce9ca20008c365ad
😎 Deploy Preview https://deploy-preview-10679--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit d043fbe.

Command Status Duration Result
nx test parser ✅ Succeeded 9s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx typecheck ast-spec ✅ Succeeded 5s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1m 9s View ↗
nx run scope-manager:test -- --coverage ✅ Succeeded 12s View ↗
nx run-many --target=clean ✅ Succeeded 19s View ↗
nx test utils ✅ Succeeded 13s View ↗
nx run typescript-eslint:test -- --coverage ✅ Succeeded 3s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 14:21:22 UTC

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 18, 2025

View your CI Pipeline Execution ↗ for commit c401e63.

Command Status Duration Result
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-18 14:24:50 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.20%. Comparing base (deacba9) to head (d043fbe).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10679      +/-   ##
==========================================
- Coverage   86.44%   81.20%   -5.24%     
==========================================
  Files         497      498       +1     
  Lines       19056    22927    +3871     
  Branches     4806     4985     +179     
==========================================
+ Hits        16473    18618    +2145     
- Misses       2285     4113    +1828     
+ Partials      298      196     -102
Flag Coverage Δ
unittest 81.20% <ø> (-5.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/typescript-estree-vitest-migration branch 3 times, most recently from 3da52df to aeae2f8 Compare January 21, 2025 17:21
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome progress! Really exciting to see a Vitest success report running yarn test locally. 🔥

Left some questions - I think most of the blockers are around _"why?"_s.

@aryaemami59 aryaemami59 force-pushed the chore/typescript-estree-vitest-migration branch 2 times, most recently from 8b6d927 to 4a4d5e7 Compare January 29, 2025 11:31
@aryaemami59 aryaemami59 mentioned this pull request Jan 29, 2025
Merged
3 tasks
@aryaemami59 aryaemami59 force-pushed the chore/typescript-estree-vitest-migration branch 17 times, most recently from 0fca021 to f66900d Compare February 3, 2025 15:51
aryaemami59 added 14 commits April 7, 2025 13:25
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
2448f19 
…t-eslint into chore/typescript-estree-vitest-migration
@aryaemami59
Fix typescript-estree tests
e407fd9
@aryaemami59
Fix typescript-estree tests
37264e5
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
cdc6281 
…t-eslint into chore/typescript-estree-vitest-migration
@aryaemami59
Update vite to version 6.2.6
11b20d5
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.40
ccff7f0
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
5208acb 
…t-eslint into chore/typescript-estree-vitest-migration
@aryaemami59
Fix typescript-estree tests
92d9f65
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
d045e12 
…t-eslint into chore/typescript-estree-vitest-migration
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.42
0b980d6
@aryaemami59
Enable the new vitest/prefer-describe-function-title rule
394f14c
@aryaemami59
Switch to it.for
0417d11
@aryaemami59
Use vitestPlugin.configs.env
66e1b09
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
2f396f8 
…t-eslint into chore/typescript-estree-vitest-migration
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 28, 2025
Closed
14 tasks
aryaemami59 and others added 12 commits April 11, 2025 10:27
@JoshuaKGoldberg JoshuaKGoldberg merged commit dfe51af into typescript-eslint:main Apr 14, 2025
58 of 59 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
@aryaemami59 aryaemami59 deleted the chore/typescript-estree-vitest-migration branch April 23, 2025 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @kirkwaiblinger