Skip to content

feat(types): add strict parent types for function-declaration, default-export and named-export nodes #10685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

feat(types): add strict parent types for function-declaration, default-export and named-export nodes #10685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/types/src/ts-estree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,34 @@ declare module './generated/ast-spec' {
| TSESTree.ImportDeclaration;
}

interface ExportDefaultDeclaration {
parent: TSESTree.BlockStatement | TSESTree.Program | TSESTree.TSModuleBlock;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSESTree.BlockStatement

TIL this does parse correctly despite the compiler complaint. Nifty.

}

interface ExportNamedDeclarationWithoutSourceWithMultiple {
parent: TSESTree.BlockStatement | TSESTree.Program | TSESTree.TSModuleBlock;
}

interface ExportNamedDeclarationWithoutSourceWithSingle {
parent: TSESTree.BlockStatement | TSESTree.Program | TSESTree.TSModuleBlock;
}

interface ExportNamedDeclarationWithSource {
parent: TSESTree.BlockStatement | TSESTree.Program | TSESTree.TSModuleBlock;
}

interface FunctionDeclarationWithName {
parent:
| TSESTree.BlockStatement
| TSESTree.ExportDefaultDeclaration
| TSESTree.ExportNamedDeclaration
| TSESTree.Program;
}

interface FunctionDeclarationWithOptionalName {
parent: TSESTree.ExportDefaultDeclaration;
}

interface JSXAttribute {
parent: TSESTree.JSXOpeningElement;
}
Expand Down
Loading