feat(eslint-plugin): add prefer-nullish-coalescing #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
be6755e to
c063cff
Compare
Summon528
reviewed
Oct 16, 2019
4ea50b9 to
9725fef
Compare
9725fef to
d295aa4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
- Coverage 94.19% 94.18% -0.01%
==========================================
Files 129 130 +1
Lines 5631 5679 +48
Branches 1582 1594 +12
==========================================
+ Hits 5304 5349 +45
- Misses 181 182 +1
- Partials 146 148 +2
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this rule is two fold:
By default, I disabled the rule on conditional tests. I found in our codebase that usually having
||for nullish types within a conditional test was intentional, and fixing it to a nullish coalesce actually caused a bug.Additionally, I disabled the rule on mixed operator logical expressions (i.e. expressions with both
&&and||). I think that if people have mixed operators, they are probably intending to do logical expressions.