Skip to content

build: decrease codecov target #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: decrease codecov target #107

wants to merge 1 commit into from

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jan 21, 2019

No description provided.

@j-f1 j-f1 mentioned this pull request Jan 21, 2019
Merged
JamesHenry
JamesHenry requested changes Jan 21, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #100 (comment) I'm not sure that PR warrants this change but would like to know your thoughts too

@j-f1
Copy link
Contributor Author

j-f1 commented Jan 21, 2019

I don’t really care either way. Happy to close if you want the higher value.

armano2
armano2 suggested changes Jan 21, 2019
View reviewed changes
Copy link
Collaborator

@armano2 armano2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm going to write better tests for parser in ts-estree

@JamesHenry JamesHenry closed this Jan 21, 2019
@JamesHenry
Copy link
Member

JamesHenry commented Jan 21, 2019 •
edited
Loading

Thanks, all!

@JamesHenry JamesHenry deleted the decrease-codecov-target branch January 21, 2019 17:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 requested changes

@JamesHenry JamesHenry JamesHenry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-f1 @JamesHenry @armano2