feat(eslint-plugin): [no-unused-var] handle implicit exports in declaration files #10714

ronami · 2025-01-26T19:21:09Z

PR Checklist

Addresses an existing open issue:
- fixes [no-unused-vars] False positives with members of exported namespace in .d.ts file #2867,
- fixes Bug: [no-unused-vars] doesn't report unused variables in module and ambient module declarations in definition files #10713
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

This PR continues #8611 and attempts to tackle #2867.

Note that I'm far from having a thorough understanding of how TypeScript handles exported values/types from a .d.ts file, and this seems to have a lot of undescribed edge cases, so I'm mainly basing this off on trying out edge cases and reverse engineering this locally.

Some notes/thoughts:

It seems namespaces, modules, and ambient module declarations without specific types of exports (export { ... }, export default ... or export * from '...', export = ...) have all of their declared variables implicitly exported (multi-file typescript playground link showing some of the cases, I've had a hard time showing other edge cases on a somewhat limited multi-file editor, can provide codesandbox/stackblitz playground URLs).

Currently, the rule only checks for export = ... syntax and only for namespace/ambient modules, though this seems to be relevant for other cases too.

To my understanding, some of this is relevant to non-definition files, mostly around declared modules and namespaces (playground link).
I've used TypeScript's 'xxx' is declared but its value is never read. messages and tried to replicate that behavior to determine whether a variable should be marked as unused or not.
It seems no-unused-vars fails to report unused variables in module and ambient module declarations in definition files (playground link).

This PR adjusts the rule to report these, though this wasn't described in the original issue. I've opened a new issue to discuss this in Bug: [no-unused-vars] doesn't report unused variables in module and ambient module declarations in definition files #10713. That issue hasn't been triaged yet, but since it's closely related to [no-unused-vars] False positives with members of exported namespace in .d.ts file #2867, it made sense to me to tackle them both on a single PR.

Please let me know if this part should be reverted (or at least if/until the former is triaged) or be in a separate PR.
Interestingly, it seems that if a default export references a variable, it will prevent that module/namespace from implicitly exporting its other, non-exported members (playgroun link). However, if the default export doesn't reference an identifier, it won't (playground link). I'm not sure if that's the correct behavior or if I missed something about this.
It seems ambient declarations (declare ...) behave similarly (playground link).
I might be missing something, but based on feat(eslint-plugin): [no-unused-var] handle implicit exports in declaration files #8611, the following, for example, should be reported with an error (playground link):
```
declare module 'foo' {
  export import Bar = Something.Bar;
  const foo: 1234;
  export const bar: string;
  export namespace NS {
    const baz: 1234;
  }
}
```
However, this seems valid, as TypeScript doesn't report any variables as unused, and an importing module can access foo.
I've continued the work done in feat(eslint-plugin): [no-unused-var] handle implicit exports in declaration files #8611, so this includes attribution for the author; please let me know if this should be changed.

…pace-dts

typescript-eslint · 2025-01-26T19:21:11Z

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-01-26T19:21:27Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`f84ded5`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67c547440a76ca000827e4b7
😎 Deploy Preview	https://deploy-preview-10714--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (🟢 up 8 from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2025-01-26T19:22:03Z

View your CI Pipeline Execution ↗ for commit f84ded5.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	4s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2025-03-03 06:23:15 UTC

codecov · 2025-01-26T19:37:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (9e8828b) to head (f84ded5).
Report is 102 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10714      +/-   ##
==========================================
+ Coverage   87.19%   87.46%   +0.27%     
==========================================
  Files         450      469      +19     
  Lines       15632    16073     +441     
  Branches     4570     4656      +86     
==========================================
+ Hits        13630    14058     +428     
- Misses       1645     1658      +13     
  Partials      357      357

Flag	Coverage Δ
unittest	`87.46% <100.00%> (+0.27%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-unused-vars.ts	`99.09% <100.00%> (+0.09%)`	⬆️

... and 65 files with indirect coverage changes

ronami · 2025-01-26T19:48:30Z

packages/eslint-plugin/src/rules/no-unused-vars.ts

-      // declaration file handling
-      [ambientDeclarationSelector(AST_NODE_TYPES.Program, true)](
+      // top-level declaration file handling
+      [ambientDeclarationSelector(AST_NODE_TYPES.Program)](


Testing various edge cases, I think that only checking `declare'd module-level values creates some incorrect reports (playground link).

Removing this didn't cause any tests to fail, though I could be missing an edge case.

ronami · 2025-02-02T18:55:27Z

packages/eslint-plugin/src/rules/no-unused-vars.ts

+        const moduleDecl = nullThrows(
+          node.parent,
+          NullThrowsReasons.MissingParent,
+        ) as TSESTree.Program;
+
+        if (checkForOverridingExportStatements(moduleDecl)) {
+          return;
+        }


This addition is so the rule would report the following (playground link):

// should be reported but doesn't declare class Foo { } export {}

Along with not reporting on the following (playground link):

// reported but shouldn't class Foo { } // even though this shows up as a compiler error, this isn't marked as used // uncomment the code below and TypeScript would mark this as unused: // export {};

ronami · 2025-02-02T19:00:31Z

packages/eslint-plugin/src/rules/no-unused-vars.ts

+      [ambientDeclarationSelector('TSModuleDeclaration > TSModuleBlock')](
+        node: DeclarationSelectorNode,
+      ): void {
+        if (!isDefinitionFile(context.filename)) {
+          return;
+        }
+        const moduleDecl = nullThrows(
+          node.parent.parent,
+          NullThrowsReasons.MissingParent,
+        ) as TSESTree.TSModuleDeclaration;
+
+        if (checkForOverridingExportStatements(moduleDecl)) {
          return;
        }


This addition is for not reporting the following (playground link):

export namespace Foo { // reported but shouldn't const foo: 1234; }

ronami · 2025-02-02T19:02:34Z

packages/eslint-plugin/src/rules/no-unused-vars.ts

+        const moduleDecl = nullThrows(
+          node.parent.parent,
+          NullThrowsReasons.MissingParent,
+        ) as TSESTree.TSModuleDeclaration;
+
+        if (checkForOverridingExportStatements(moduleDecl)) {
+          return;
+        }


This is necessary so the following is reported (playground link):

export declare namespace Foo { namespace Bar { namespace Baz { // should be reported but isn't namespace Bam { const x = 1; } export { }; } } }

JoshuaKGoldberg

Whew! What a PR. This is a tricky rule. I had to go in and out of the old & new code a few times to get a feel for it.

I think everything you're saying makes sense. As I understand it, the main changes around the new hasOverridingExportStatement & the removal of the no-longer-necessary child selectors seem correct. Anything that reduces ambientDeclarationSelector's complexity is off to a good start. 😄

👍 from me on all the edge cases as described. I think we should get another review from @typescript-eslint/triage-team just to be thorough.

JoshuaKGoldberg · 2025-02-17T12:51:35Z

packages/eslint-plugin/src/rules/no-unused-vars.ts

@@ -144,7 +144,10 @@ export default createRule<Options, MessageIds>({
  },
  defaultOptions: [{}],
  create(context, [firstOption]) {
-    const MODULE_DECL_CACHE = new Map<TSESTree.TSModuleDeclaration, boolean>();
+    const MODULE_DECL_CACHE = new Map<
+      TSESTree.Program | TSESTree.TSModuleDeclaration,


[Refactor] The .body seems to be assumed to always exist in code. So I think anywhere that refers to the TSModuleDeclaration type can assume this:

type ModuleDeclarationWithBody = MakeRequired<TSESTree.TSModuleDeclaration, 'body'>;

Suggested change

TSESTree.Program | TSESTree.TSModuleDeclaration,

TSESTree.Program | ModuleDeclarationWithBody,

...which means the 'Module declarations with no body are filtered out by the rule' nullThrows can be removed.

(unless, did I misinterpret?)

Nice! I've updated the PR with your suggestion, thanks 👍

JoshuaKGoldberg · 2025-02-17T13:11:56Z

packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts

[Praise] Really thorough investigation and tests. Nicely done! 👏

jakebailey · 2025-02-17T18:23:50Z

This would probably be a lot of work (so I can attempt to do it when I have a chance), but the thing I want to test most is to enable this rule on DT and then verify that what it says makes sense; declaration files have so many edge cases...

jakebailey · 2025-02-17T18:25:03Z

packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts

+          messageId: 'unusedVar',
+        },
+      ],
+      filename: 'foo.d.ts',


One thing I would do here as well is to ensure there's testing for .d.cts and .d.mts files (and their associated syntaxes).

typescript-eslint/packages/eslint-plugin/src/util/misc.ts

Lines 13 to 29 in 3646ec0

const DEFINITION_EXTENSIONS = [

ts.Extension.Dts,

ts.Extension.Dcts,

ts.Extension.Dmts,

] as const;

/**

* Check if the context file name is *.d.ts or *.d.tsx

*/

export function isDefinitionFile(fileName: string): boolean {

const lowerFileName = fileName.toLowerCase();

for (const definitionExt of DEFINITION_EXTENSIONS) {

if (lowerFileName.endsWith(definitionExt)) {

return true;

}

}

return false;

}

It's covered by this utility so it'll work as expected so long as this utility is right!

Ah, unfortunately that function is incomplete because it doesn't handle filenames like .d.css.ts ☹️

(dt-tools uses a glob https://github.com/microsoft/DefinitelyTyped-tools/blob/1f6e243b03e6d557bf43e6312b0b8f2d47819e52/packages/utils/src/miscellany.ts#L97)

Are those other file names officially supported by TS...?
We don't really want to be in the business of guessing if a file might be a decl file.

Yes, since TS 5.0; the feature is used to provide declarations to files with non-TS extensions, e.g. a .d.css.ts file can provide types for importing a .css file.

https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#allowarbitraryextensions

I've opened #10911 to discuss this 👍

bradzacher

Great work!
If you can I'd suggest trying the rule over the DefinitelyTyped repo to look for false positives. There'll be a lot of noise so worth time-boxing it -- but would be a good final validation that you haven't missed anything.

ronami · 2025-03-02T21:57:47Z

Great work! If you can I'd suggest trying the rule over the DefinitelyTyped repo to look for false positives. There'll be a lot of noise so worth time-boxing it -- but would be a good final validation that you haven't missed anything.

Thanks!

I've checked quite a bit of declaration files from definitelytyped, here are some of the types that this PR affects:

ember - fixes a bunch of false positives (main branch playground link vs deploy preview playground link)
react-rte - reports two valid errors that are currently missed (main branch playground link vs deploy preview playground link)
punycode - fixes 2 false positives (main branch playground link vs deploy preview playground link)
aes-js - fixes 19 false positives (main branch playground link vs deploy preview playground link)
jshint - fixes 4 false positives (main branch playground link vs deploy preview playground link)
logger - fixes a false positive (main branch playground link vs deploy preview playground link)
react/canary - reports a valid error that's currently missed (main branch playground link vs deploy preview playground link)
react-tree-graph - reports a valid error that's currently missed (main branch playground link vs deploy preview playground link)

I checked only a small subset of definitelytyped's types, but I didn't find any incorrect or missing reports (I've relied on TypeScript's xxx is declared but its value is never read. warnings).

jakebailey · 2025-03-02T22:04:05Z

On that first one, I'm actually surprised we are flagging stateFromHTML and stateToHTML as unused; I had thought that without export {} that everything was implicitly exported in a declaration file, but maybe there's nuance there? The playground links are setting the extension .d.ts so it's not that or anything.

ronami · 2025-03-02T22:48:14Z

On that first one, I'm actually surprised we are flagging stateFromHTML and stateToHTML as unused; I had thought that without export {} that everything was implicitly exported in a declaration file, but maybe there's nuance there? The playground links are setting the extension .d.ts so it's not that or anything.

To my understanding, in addition to export {}, the following also prevent a declaration file from implicitly exporting everything: export { ... }, export default ..., export * from '...', and export = ....

Removing the export default ... at the bottom removes TypeScript's (and ts-eslint's) unused reports (playground link).

jakebailey · 2025-03-02T23:05:14Z

That'd make some sense, yeah.

(Well, not that d.ts export rules make any sense at all.)

bradzacher

LGTM -- with the DefinitelyTyped testing I think we're good to go here.

bradzacher · 2025-03-03T01:47:08Z

We have some lint errors -- pls fix and we can merge!

@jfet97

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.24.0 | 8.26.0 | | npm | @typescript-eslint/parser | 8.24.0 | 8.26.0 | ## [v8.26.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8260-2025-03-03) ##### 🚀 Features - **eslint-plugin:** \[unified-signatures] support ignoring overload signatures with different JSDoc comments ([#10781](typescript-eslint/typescript-eslint#10781)) - **eslint-plugin:** \[explicit-module-boundary-types] add an option to ignore overload implementations ([#10889](typescript-eslint/typescript-eslint#10889)) - **eslint-plugin:** \[no-unused-var] handle implicit exports in declaration files ([#10714](typescript-eslint/typescript-eslint#10714)) - support TypeScript 5.8 ([#10903](typescript-eslint/typescript-eslint#10903)) - **eslint-plugin:** \[no-unnecessary-type-parameters] special case tuples and parameter location arrays as single-use ([#9536](typescript-eslint/typescript-eslint#9536)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-type-assertion] handle unknown ([#10875](typescript-eslint/typescript-eslint#10875)) - **eslint-plugin:** \[no-invalid-void-type] report `accessor` properties with an invalid `void` type ([#10864](typescript-eslint/typescript-eslint#10864)) - **eslint-plugin:** \[unified-signatures] does not differentiate truly private methods ([#10806](typescript-eslint/typescript-eslint#10806)) ##### ❤️ Thank You - Andrea Simone Costa [@jfet97](https://github.com/jfet97) - Dirk Luijk [@dirkluijk](https://github.com/dirkluijk) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.25.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8250-2025-02-24) ##### 🚀 Features - **eslint-plugin:** \[no-misused-spread] add suggestions ([#10719](typescript-eslint/typescript-eslint#10719)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] report on chain expressions in a ternary ([#10708](typescript-eslint/typescript-eslint#10708)) - **eslint-plugin:** \[no-deprecated] report usage of deprecated private identifiers ([#10844](typescript-eslint/typescript-eslint#10844)) - **eslint-plugin:** \[unified-signatures] handle getter-setter ([#10818](typescript-eslint/typescript-eslint#10818)) ##### ❤️ Thank You - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.24.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8241-2025-02-17) ##### 🩹 Fixes - **eslint-plugin:** \[class-methods-use-this] check `accessor` methods with a function initializer ([#10796](typescript-eslint/typescript-eslint#10796)) - **eslint-plugin:** \[no-misused-promises] don't report on `static` `accessor` properties ([#10814](typescript-eslint/typescript-eslint#10814)) - **eslint-plugin:** \[no-deprecated] don't report on deprecated `accessor` property declaration ([#10813](typescript-eslint/typescript-eslint#10813)) - **eslint-plugin:** \[explicit-member-accessibility] check `accessor` class properties for missing accessibility modifier ([#10805](typescript-eslint/typescript-eslint#10805)) - **eslint-plugin:** \[explicit-module-boundary-types] check `accessor` class properties with a function initializer ([#10804](typescript-eslint/typescript-eslint#10804)) - **eslint-plugin:** \[prefer-return-this-type] check `accessor` properties with a function initializer ([#10794](typescript-eslint/typescript-eslint#10794)) - **eslint-plugin:** \[consistent-generic-constructors] check `accessor` class properties ([#10789](typescript-eslint/typescript-eslint#10789)) - **eslint-plugin:** \[no-unsafe-assignment] report on an `any` value assigned as an initializer of an `accessor` property ([#10785](typescript-eslint/typescript-eslint#10785)) - **eslint-plugin:** \[no-unnecessary-template-expression] ignore enum and enum members ([#10782](typescript-eslint/typescript-eslint#10782)) - **eslint-plugin:** \[no-inferrable-types] handle accessor ([#10780](typescript-eslint/typescript-eslint#10780)) ##### ❤️ Thank You - Ronen Amiel - YeonJuan You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

jakebailey and others added 6 commits March 2, 2024 20:41

WIP

7117fcc

WIP

3d2fc3b

revert nx

f9f18c5

Merge remote-tracking branch 'origin/main' into implicit-export-names…

2264c7d

…pace-dts

initial implementation

02d1b06

change implementation to use existing ambient code

e307ce3

ronami commented Jan 26, 2025

View reviewed changes

ronami mentioned this pull request Jan 26, 2025

Bug: [no-unused-vars] doesn't report unused variables in module and ambient module declarations in definition files #10713

Closed

4 tasks

ronami commented Feb 2, 2025

View reviewed changes

ronami marked this pull request as ready for review February 3, 2025 20:07

JoshuaKGoldberg mentioned this pull request Feb 17, 2025

feat(eslint-plugin): [no-unused-var] handle implicit exports in declaration files #8611

Closed

7 tasks

JoshuaKGoldberg previously approved these changes Feb 17, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Feb 17, 2025

JoshuaKGoldberg requested a review from a team February 17, 2025 13:11

github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Feb 17, 2025

JoshuaKGoldberg reviewed Feb 17, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Feb 17, 2025

jakebailey reviewed Feb 17, 2025

View reviewed changes

bradzacher previously approved these changes Feb 17, 2025

View reviewed changes

ronami mentioned this pull request Mar 2, 2025

Bug: isDefinitionFile utility doesn't consider arbitrary extensions #10911

Closed

4 tasks

refactor

4eb0d58

ronami dismissed stale reviews from bradzacher and JoshuaKGoldberg via 4eb0d58 March 2, 2025 23:32

bradzacher previously approved these changes Mar 3, 2025

View reviewed changes

fix lint

f84ded5

ronami dismissed bradzacher’s stale review via f84ded5 March 3, 2025 06:08

bradzacher merged commit d8d4b3c into typescript-eslint:main Mar 3, 2025
90 of 91 checks passed

ronami deleted the implicit-export-namespace-dts-unused-vars branch March 6, 2025 10:32

github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [no-unused-var] handle implicit exports in declaration files #10714

feat(eslint-plugin): [no-unused-var] handle implicit exports in declaration files #10714

ronami commented Jan 26, 2025 •

edited

Loading

typescript-eslint bot commented Jan 26, 2025

netlify bot commented Jan 26, 2025 •

edited

Loading

nx-cloud bot commented Jan 26, 2025 •

edited

Loading

codecov bot commented Jan 26, 2025 •

edited

Loading

ronami Jan 26, 2025 •

edited

Loading

ronami Feb 2, 2025

ronami Feb 2, 2025 •

edited

Loading

ronami Feb 2, 2025

JoshuaKGoldberg left a comment

JoshuaKGoldberg Feb 17, 2025

ronami Mar 2, 2025

JoshuaKGoldberg Feb 17, 2025

jakebailey commented Feb 17, 2025

jakebailey Feb 17, 2025

bradzacher Feb 17, 2025

jakebailey Feb 17, 2025

bradzacher Feb 17, 2025

jakebailey Feb 17, 2025

ronami Mar 2, 2025

bradzacher left a comment

ronami commented Mar 2, 2025 •

edited

Loading

jakebailey commented Mar 2, 2025

ronami commented Mar 2, 2025 •

edited

Loading

jakebailey commented Mar 2, 2025 •

edited

Loading

bradzacher left a comment

bradzacher commented Mar 3, 2025

	TSESTree.Program \| TSESTree.TSModuleDeclaration,
	TSESTree.Program \| ModuleDeclarationWithBody,

	const DEFINITION_EXTENSIONS = [
	ts.Extension.Dts,
	ts.Extension.Dcts,
	ts.Extension.Dmts,
	] as const;
	/**
	* Check if the context file name is .d.ts or .d.tsx
	*/
	export function isDefinitionFile(fileName: string): boolean {
	const lowerFileName = fileName.toLowerCase();
	for (const definitionExt of DEFINITION_EXTENSIONS) {
	if (lowerFileName.endsWith(definitionExt)) {
	return true;
	}
	}
	return false;
	}

feat(eslint-plugin): [no-unused-var] handle implicit exports in declaration files #10714

feat(eslint-plugin): [no-unused-var] handle implicit exports in declaration files #10714

Conversation

ronami commented Jan 26, 2025 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Jan 26, 2025

netlify bot commented Jan 26, 2025 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Jan 26, 2025 • edited Loading

codecov bot commented Jan 26, 2025 • edited Loading

Codecov Report

ronami Jan 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ronami Feb 2, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakebailey commented Feb 17, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bradzacher left a comment

Choose a reason for hiding this comment

ronami commented Mar 2, 2025 • edited Loading

jakebailey commented Mar 2, 2025

ronami commented Mar 2, 2025 • edited Loading

jakebailey commented Mar 2, 2025 • edited Loading

bradzacher left a comment

Choose a reason for hiding this comment

bradzacher commented Mar 3, 2025

ronami commented Jan 26, 2025 •

edited

Loading

netlify bot commented Jan 26, 2025 •

edited

Loading

nx-cloud bot commented Jan 26, 2025 •

edited

Loading

codecov bot commented Jan 26, 2025 •

edited

Loading

ronami Jan 26, 2025 •

edited

Loading

ronami Feb 2, 2025 •

edited

Loading

ronami commented Mar 2, 2025 •

edited

Loading

ronami commented Mar 2, 2025 •

edited

Loading

jakebailey commented Mar 2, 2025 •

edited

Loading