Skip to content

docs: replace link to deprecated rule #10716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TJNhxMZHmqGytuWT
Copy link
Contributor

@TJNhxMZHmqGytuWT TJNhxMZHmqGytuWT commented Jan 27, 2025

PR Checklist

Overview

Replaces a link to the deprecated no-var-requires rule by the recommended no-require-imports rule.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @TJNhxMZHmqGytuWT!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b20540d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6797173bbfe4940008712adb
😎 Deploy Preview https://deploy-preview-10716--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jan 27, 2025

View your CI Pipeline Execution ↗ for commit b20540d.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 1s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-27 15:47:40 UTC

@TJNhxMZHmqGytuWT TJNhxMZHmqGytuWT changed the title docs: Replace link to deprecated rule docs: replace link to deprecated rule Jan 27, 2025
@TJNhxMZHmqGytuWT TJNhxMZHmqGytuWT marked this pull request as ready for review January 27, 2025 05:36
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 27, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 252e11b into typescript-eslint:main Feb 3, 2025
70 of 71 checks passed
@TJNhxMZHmqGytuWT TJNhxMZHmqGytuWT deleted the replace-link-deprecated-rule branch February 7, 2025 17:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants