Skip to content

chore: ignore generated docs in markdownlint #10727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

chore: ignore generated docs in markdownlint #10727

merged 1 commit into from
Jan 31, 2025

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 28, 2025 •
edited
Loading

PR Checklist

Overview

Also alphabetizes the file while I'm in the area. 🤘

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 89fcce6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6798d5a546ea7a0008cadb85
😎 Deploy Preview https://deploy-preview-10727--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 87 (🔴 down 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 89fcce6.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 19:29:30 UTC

ronami
ronami approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 Nice!

I'm surprised markdownlint-cli doesn't ignore files specified in the .gitignore file (if it's in the same cwd) by default (prettier seems to do so).

@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 28, 2025
@JoshuaKGoldberg
Copy link
Member Author

Ooh, yes, maybe a good feature request for them...

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3372a4a into typescript-eslint:main Jan 31, 2025
65 of 68 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the markdownlintignore-docs-generated branch January 31, 2025 13:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ronami ronami ronami approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: markdownlint should ignore docs/packages/ast-spec/generated/index.md
2 participants
@JoshuaKGoldberg @ronami