Skip to content

docs(eslint-plugin): [prefer-nullish-coalescing] streamline code examples #10735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 3, 2025
Merged

docs(eslint-plugin): [prefer-nullish-coalescing] streamline code examples #10735

merged 7 commits into from
Feb 3, 2025

Conversation

OlivierZal
Copy link
Contributor

@OlivierZal OlivierZal commented Jan 28, 2025 •
edited by kirkwaiblinger
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bee3fdb
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67a0f3d8b6e66500089fca20
😎 Deploy Preview https://deploy-preview-10735--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bee3fdb.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 5m 57s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 7m 52s View ↗
nx test utils ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test visitor-keys ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 28s View ↗
nx test typescript-eslint ✅ Succeeded 5s View ↗
nx test scope-manager ✅ Succeeded <1s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-03 17:11:16 UTC

@OlivierZal OlivierZal marked this pull request as draft January 28, 2025 20:55
@OlivierZal OlivierZal force-pushed the prefer-nullish-coalescing-10566 branch 3 times, most recently from 2911abe to e7bd52d Compare January 28, 2025 22:27
@OlivierZal OlivierZal force-pushed the prefer-nullish-coalescing-10566 branch from e7bd52d to 3d9cb2e Compare January 28, 2025 22:37
@OlivierZal OlivierZal marked this pull request as ready for review January 28, 2025 22:38
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (06925f8) to head (bee3fdb).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10735      +/-   ##
==========================================
- Coverage   87.28%   87.28%   -0.01%     
==========================================
  Files         450      450              
  Lines       15739    15739              
  Branches     4609     4609              
==========================================
- Hits        13738    13737       -1     
  Misses       1645     1645              
- Partials      356      357       +1
Flag Coverage Δ
unittest 87.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@OlivierZal OlivierZal marked this pull request as draft February 1, 2025 09:18
@OlivierZal OlivierZal marked this pull request as ready for review February 1, 2025 10:36
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Will defer to @kirkwaiblinger ~

@OlivierZal
Copy link
Contributor Author

https://deploy-preview-10735--typescript-eslint.netlify.app/rules/prefer-nullish-coalescing/

ronami
ronami requested changes Feb 2, 2025
View reviewed changes
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for pushing this, just requesting changes around the code examples 👍👍

@ronami ronami added the awaiting response Issues waiting for a reply from the OP or another party label Feb 2, 2025
@OlivierZal OlivierZal requested a review from ronami February 2, 2025 22:21
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Feb 2, 2025
@OlivierZal
Copy link
Contributor Author

Hi @ronami, thanks for your review! Examples fixed.

ronami
ronami previously approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@OlivierZal
Copy link
Contributor Author

OlivierZal commented Feb 2, 2025 •
edited
Loading

2 remaining checks seem to be stuck but it looks good: https://deploy-preview-10735--typescript-eslint.netlify.app/rules/prefer-nullish-coalescing

@kirkwaiblinger kirkwaiblinger changed the title docs(eslint-plugin): [prefer-nullish-coalescing] streamline code exam… docs(eslint-plugin): [prefer-nullish-coalescing] streamline code examples Feb 3, 2025
kirkwaiblinger
kirkwaiblinger previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner and better. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg dismissed stale reviews from kirkwaiblinger and ronami via bee3fdb February 3, 2025 16:50
@JoshuaKGoldberg JoshuaKGoldberg merged commit bcdf560 into typescript-eslint:main Feb 3, 2025
62 checks passed
@OlivierZal OlivierZal deleted the prefer-nullish-coalescing-10566 branch February 3, 2025 19:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ronami ronami ronami left review comments

@kirkwaiblinger kirkwaiblinger kirkwaiblinger left review comments

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [prefer-nullish-coalescing] streamline code examples
4 participants
@OlivierZal @JoshuaKGoldberg @ronami @kirkwaiblinger