Skip to content

chore(eslint-plugin): migrate from jest to vitest #10764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d729506
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fa1925b4086e000830eba4
😎 Deploy Preview https://deploy-preview-10764--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Feb 3, 2025

View your CI Pipeline Execution ↗ for commit d729506.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 6m 9s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 30s View ↗
nx test typescript-estree ✅ Succeeded 1m 16s View ↗
nx test eslint-plugin-internal ✅ Succeeded 11s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test scope-manager ✅ Succeeded 14s View ↗
nx typecheck ast-spec ✅ Succeeded 5s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1m 11s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-12 07:59:15 UTC

@aryaemami59 aryaemami59 force-pushed the chore/eslint-plugin-vitest-migration branch 4 times, most recently from 39a3da7 to 6917f3e Compare February 3, 2025 18:08
@aryaemami59 aryaemami59 marked this pull request as ready for review February 3, 2025 18:12
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (0f9b55d) to head (d729506).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10764      +/-   ##
==========================================
+ Coverage   87.68%   94.32%   +6.64%     
==========================================
  Files         486      497      +11     
  Lines       15910    39611   +23701     
  Branches     4602     7933    +3331     
==========================================
+ Hits        13950    37362   +23412     
- Misses       1615     2060     +445     
+ Partials      345      189     -156     
Flag Coverage Δ
unittest 94.32% <ø> (+6.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 234 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/eslint-plugin-vitest-migration branch 18 times, most recently from 582f81f to ef7f376 Compare February 8, 2025 09:05
@aryaemami59 aryaemami59 force-pushed the chore/eslint-plugin-vitest-migration branch from ef7f376 to 090a59a Compare February 8, 2025 09:36
@JoshuaKGoldberg
Copy link
Member

Closing in favor of #10579.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants