typescript-eslint · aryaemami59 · Feb 3, 2025 · Mar 7, 2025 · Mar 7, 2025 · Mar 7, 2025
diff --git a/.github/actions/prepare-build/action.yml b/.github/actions/prepare-build/action.yml
@@ -22,7 +22,7 @@ runs:
       if: steps['build-cache'].outputs.cache-hit == 'true'
       shell: bash
       run: |
-        npx nx run types:build
+        yarn nx run types:build
       env:
         SKIP_AST_SPEC_REBUILD: true
 
@@ -31,6 +31,6 @@ runs:
       shell: bash
       # Website will be built by the Netlify GitHub App
       run: |
-        npx nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
+        yarn nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
       env:
         SKIP_AST_SPEC_REBUILD: true
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -198,12 +198,12 @@ jobs:
       # we don't collect coverage on other node versions so they run faster
       - name: Run unit tests with coverage for ${{ matrix.package }}
         if: env.PRIMARY_NODE_VERSION == matrix.node-version && matrix.os == 'ubuntu-latest'
-        run: npx nx run ${{ matrix.package }}:test -- --coverage
+        run: yarn nx run ${{ matrix.package }}:test -- --coverage
         env:
           CI: true
       - name: Run unit tests for ${{ matrix.package }}
         if: env.PRIMARY_NODE_VERSION != matrix.node-version || matrix.os != 'ubuntu-latest'
-        run: npx nx test ${{ matrix.package }}
+        run: yarn nx test ${{ matrix.package }}
         env:
           CI: true
 
@@ -238,7 +238,7 @@ jobs:
       - name: Build
         uses: ./.github/actions/prepare-build
       - name: Run unit tests for ${{ matrix.package }}
-        run: npx nx test ${{ matrix.package }} --coverage=false
+        run: yarn nx test ${{ matrix.package }} --coverage=false
         env:
           CI: true
           TYPESCRIPT_ESLINT_PROJECT_SERVICE: true

diff --git a/knip.ts b/knip.ts
@@ -22,20 +22,17 @@ export default {
   workspaces: {
     '.': {
       entry: ['tools/release/changelog-renderer.js', 'tools/scripts/**/*.mts'],
-      ignore: ['tools/scripts/typings/typescript.d.ts', 'typings/*.d.ts'],
       ignoreDependencies: [
-        '@babel/code-frame',
-        '@babel/core',
-        '@babel/eslint-parser',
-        '@babel/parser',
-        '@babel/types',
-        '@nx/js',
         '@nx/workspace',
-        'glob',
-        'make-dir',
         // imported for type purposes only
         'website',
       ],
+
+      project: [
+        'tools/scripts/**/*.mts',
+        '!tools/scripts/typings/typescript.d.ts',
+        '!typings/*.d.ts',
+      ],
     },
     'packages/ast-spec': {
       ignore: [

diff --git a/nx.json b/nx.json
@@ -66,6 +66,16 @@
       "outputs": ["{projectRoot}/coverage"],
       "cache": true
     },
+    "@nx/eslint:lint": {
+      "dependsOn": ["eslint-plugin-internal:build", "typescript-eslint:build"],
+      "options": {
+        "noEslintrc": true,
+        "cache": true,
+        "eslintConfig": "{workspaceRoot}/eslint.config.mjs"
+      },
+      "outputs": ["{options.outputFile}"],
+      "cache": true
+    },
     "@nx/vite:test": {
       "dependsOn": ["^build"],
       "inputs": [
@@ -84,14 +94,9 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "dependsOn": [
-        "eslint-plugin:build",
-        "eslint-plugin-internal:build",
-        "typescript-eslint:build"
-      ],
+      "dependsOn": ["eslint-plugin-internal:build", "typescript-eslint:build"],
       "inputs": [
         "default",
-        "{workspaceRoot}/eslint.config.js",
         "{workspaceRoot}/eslint.config.mjs",
         {
           "dependentTasksOutputFiles": "**/*.js",
@@ -124,9 +129,10 @@
     ],
     "production": [
       "default",
-      "!{projectRoot}/**/?(*.)+(test).[jt]s?(x)?(.snap)",
+      "!{projectRoot}/**/?(*.)+(test).?(m|c)[jt]s?(x)?(.snap|.shot)",
+      "!{projectRoot}/tests",
       "!{projectRoot}/tsconfig.spec.json",
-      "!{projectRoot}/vitest.config.m[jt]s",
+      "!{projectRoot}/vitest.config.mts",
       "!{projectRoot}/src/test-setup.[jt]s"
     ]
   }

diff --git a/package.json b/package.json
@@ -22,53 +22,47 @@
   },
   "homepage": "https://typescript-eslint.io",
   "scripts": {
-    "build": "npx nx run-many --target=build --exclude website --exclude website-eslint",
+    "build": "nx run-many --target=build --exclude website --exclude website-eslint",
     "check-clean-workspace-after-install": "git diff --quiet --exit-code",
     "check-format": "prettier --check .",
     "check-spelling": "cspell --config=.cspell.json \"**/*.{md,mdx,ts,mts,cts,js,cjs,mjs,tsx,jsx}\" --no-progress --show-context --show-suggestions",
-    "clean": "npx nx run-many --target=clean",
-    "format": "prettier --write .",
-    "generate-breaking-changes": "npx nx run eslint-plugin:generate-breaking-changes",
-    "generate-configs": "npx nx generate-configs",
-    "generate-contributors": "npx nx generate-contributors",
-    "generate-lib": "npx nx generate-lib",
-    "generate-sponsors": "npx nx generate-sponsors",
-    "generate-website-dts": "npx nx run website:generate-website-dts",
+    "clean": "nx run-many --target=clean --parallel=20",
+    "format": "prettier --ignore-path=$PROJECT_CWD/.prettierignore --config=$PROJECT_CWD/.prettierrc.json --write $INIT_CWD",
+    "generate-breaking-changes": "nx run eslint-plugin:generate-breaking-changes",
+    "generate-configs": "nx generate-configs",
+    "generate-contributors": "nx generate-contributors",
+    "generate-lib": "nx generate-lib",
+    "generate-sponsors": "nx generate-sponsors",
+    "generate-website-dts": "nx run website:generate-website-dts",
     "lint-fix": "yarn lint --fix",
     "lint-markdown-fix": "yarn lint-markdown --fix",
     "lint-markdown": "markdownlint \"**/*.md\" --config=.markdownlint.json --ignore-path=.markdownlintignore",
-    "lint-stylelint": "npx nx lint website stylelint",
-    "lint": "npx nx lint eslint-plugin --skip-nx-cache && npx nx run-many --target=lint --exclude eslint-plugin",
+    "lint-stylelint": "nx lint website stylelint",
+    "lint": "nx run-many --target=lint",
     "postinstall": "tsx tools/scripts/postinstall.mts",
-    "pre-commit": "yarn lint-staged",
+    "pre-commit": "lint-staged",
     "release": "tsx tools/release/release.mts",
-    "start": "npx nx run website:start",
-    "test": "npx nx run-many --target=test --exclude integration-tests --exclude website --exclude website-eslint",
-    "test-integration": "npx nx run integration-tests:test",
-    "typecheck": "npx nx run-many --target=typecheck"
+    "start": "nx run website:start",
+    "test": "nx run-many --target=test --exclude integration-tests --exclude website --exclude website-eslint",
+    "test-integration": "nx run integration-tests:test",
+    "typecheck": "nx run-many --target=typecheck"
   },
   "engines": {
     "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
   },
   "devDependencies": {
     "@actions/core": "^1.10.1",
     "@actions/github": "^6.0.0",
-    "@babel/code-frame": "^7.24.2",
-    "@babel/core": "^7.24.4",
-    "@babel/eslint-parser": "^7.24.1",
-    "@babel/parser": "^7.24.4",
-    "@babel/types": "^7.24.0",
     "@eslint-community/eslint-plugin-eslint-comments": "^4.4.1",
     "@eslint/compat": "^1.2.4",
     "@eslint/eslintrc": "^3.2.0",
     "@eslint/js": "^9.15.0",
     "@nx/devkit": "20.7.2",
     "@nx/eslint": "20.7.2",
+    "@nx/js": "20.7.2",
     "@nx/vite": "20.7.2",
     "@nx/workspace": "20.7.2",
     "@swc/core": "^1.4.12",
-    "@types/babel__code-frame": "^7.0.6",
-    "@types/babel__core": "^7.20.5",
     "@types/debug": "^4.1.12",
     "@types/eslint-plugin-jsx-a11y": "^6.10.0",
     "@types/is-glob": "^4.0.4",
@@ -78,6 +72,7 @@
     "@types/yargs": "^17.0.32",
     "@typescript-eslint/eslint-plugin": "workspace:^",
     "@typescript-eslint/eslint-plugin-internal": "workspace:^",
+    "@typescript-eslint/parser": "workspace:^",
     "@typescript-eslint/scope-manager": "workspace:^",
     "@typescript-eslint/types": "workspace:^",
     "@typescript-eslint/typescript-estree": "workspace:^",
@@ -98,17 +93,13 @@
     "eslint-plugin-regexp": "^2.7.0",
     "eslint-plugin-unicorn": "^56.0.0",
     "execa": "7.2.0",
-    "glob": "^10.3.12",
     "globals": "^15.0.0",
     "husky": "^9.1.4",
-    "jiti": "2.4.2",
     "knip": "^5.41.1",
     "lint-staged": "^15.2.2",
-    "make-dir": "^4.0.0",
     "markdownlint-cli": "^0.44.0",
     "nx": "20.7.2",
     "prettier": "3.5.0",
-    "pretty-format": "^29.7.0",
     "rimraf": "^5.0.5",
     "semver": "7.7.0",
     "tsx": "*",
@@ -128,7 +119,6 @@
     "prettier": "3.5.0",
     "pretty-format": "^29",
     "react-split-pane@^0.1.92": "patch:react-split-pane@npm%3A0.1.92#./.yarn/patches/react-split-pane-npm-0.1.92-93dbf51dff.patch",
-    "tmp": "0.2.1",
     "tsx": "^4.7.2",
     "typescript": "5.8.2",
     "@eslint/config-helpers": "^0.2.0"

diff --git a/packages/ast-spec/package.json b/packages/ast-spec/package.json
@@ -31,29 +31,30 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {
-    "build": "tsc -b tsconfig.build.json && api-extractor run --local",
-    "clean": "tsc -b tsconfig.build.json --clean",
-    "postclean": "rimraf dist/ coverage/",
+    "build": "tsc -b tsconfig.build.json && api-extractor run --local --config=$INIT_CWD/api-extractor.json",
+    "clean": "rimraf dist/ coverage/",
     "clean-fixtures": "rimraf -g \"./src/**/fixtures/**/snapshots\"",
-    "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
-    "lint": "npx nx lint",
+    "format": "yarn run -T format",
+    "lint": "yarn run -BT nx lint",
     "test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
-    "check-types": "npx nx typecheck"
+    "check-types": "yarn run -BT nx typecheck"
   },
   "funding": {
     "type": "opencollective",
     "url": "https://opencollective.com/typescript-eslint"
   },
   "devDependencies": {
-    "@babel/code-frame": "*",
-    "@babel/core": "*",
-    "@babel/eslint-parser": "*",
+    "@babel/code-frame": "^7.24.2",
+    "@babel/core": "^7.24.4",
+    "@babel/eslint-parser": "^7.24.1",
     "@microsoft/api-extractor": "^7.47.11",
+    "@types/babel__code-frame": "^7.0.6",
+    "@types/babel__core": "^7.20.5",
     "@typescript-eslint/typescript-estree": "workspace:*",
     "@vitest/coverage-v8": "^3.1.1",
+    "eslint": "*",
     "glob": "*",
     "jest-diff": "^29.7.0",
-    "prettier": "^3.2.5",
     "pretty-format": "*",
     "rimraf": "*",
     "typescript": "*",

diff --git a/packages/ast-spec/project.json b/packages/ast-spec/project.json
@@ -10,8 +10,7 @@
       "outputs": ["{projectRoot}/dist/**/*.ts"]
     },
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"]
+      "executor": "@nx/eslint:lint"
     },
     "test": {
       "executor": "@nx/vite:test",

diff --git a/packages/eslint-plugin-internal/package.json b/packages/eslint-plugin-internal/package.json
@@ -14,13 +14,12 @@
   "homepage": "https://typescript-eslint.io",
   "license": "MIT",
   "scripts": {
-    "build": "npx tsc -b tsconfig.build.json",
-    "clean": "npx tsc -b tsconfig.build.json --clean",
-    "postclean": "rimraf dist/ coverage/",
-    "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
-    "lint": "npx nx lint",
+    "build": "tsc -b tsconfig.build.json",
+    "clean": "rimraf dist/ coverage/",
+    "format": "yarn run -T format",
+    "lint": "yarn run -BT nx lint",
     "test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
-    "check-types": "npx nx typecheck"
+    "check-types": "yarn run -BT nx typecheck"
   },
   "dependencies": {
     "@prettier/sync": "^0.5.1",

diff --git a/packages/eslint-plugin-internal/project.json b/packages/eslint-plugin-internal/project.json
@@ -6,8 +6,7 @@
   "sourceRoot": "packages/eslint-plugin-internal/src",
   "targets": {
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"]
+      "executor": "@nx/eslint:lint"
     },
     "test": {
       "executor": "@nx/vite:test"

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -50,15 +50,14 @@
   ],
   "scripts": {
     "build": "tsc -b tsconfig.build.json",
-    "clean": "tsc -b tsconfig.build.json --clean",
-    "postclean": "rimraf dist && rimraf coverage",
-    "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
-    "generate:breaking-changes": "tsx tools/generate-breaking-changes.mts",
-    "generate:configs": "npx nx generate-configs repo",
-    "lint": "npx nx lint",
+    "clean": "rimraf dist/ coverage/",
+    "format": "yarn run -T format",
+    "generate-breaking-changes": "tsx tools/generate-breaking-changes.mts",
+    "generate-configs": "yarn run -T generate-configs",
+    "lint": "yarn run -BT nx lint",
     "test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
-    "test-single": "vitest --run --config=$INIT_CWD/vitest.config.mts",
-    "check-types": "npx nx typecheck"
+    "test-single": "vitest --run --config=$INIT_CWD/vitest.config.mts --no-coverage",
+    "check-types": "yarn run -BT nx typecheck"
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",
@@ -87,7 +86,7 @@
     "mdast-util-from-markdown": "^2.0.0",
     "mdast-util-mdx": "^3.0.0",
     "micromark-extension-mdxjs": "^3.0.0",
-    "prettier": "^3.2.5",
+    "prettier": "^3.5.3",
     "rimraf": "*",
     "title-case": "^3.0.3",
     "tsx": "*",

diff --git a/packages/eslint-plugin/project.json b/packages/eslint-plugin/project.json
@@ -1,17 +1,28 @@
 {
   "name": "eslint-plugin",
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
-  "type": "library",
-  "implicitDependencies": [],
+  "projectType": "library",
+  "root": "packages/eslint-plugin",
+  "sourceRoot": "packages/eslint-plugin/src",
   "targets": {
     "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"]
+      "executor": "@nx/eslint:lint"
+    },
+    "test-single": {
+      "cache": false,
+      "executor": "@nx/vite:test",
+      "options": {
+        "coverage": false
+      }
+    },
+    "test": {
+      "executor": "@nx/vite:test"
     },
     "generate-breaking-changes": {
+      "dependsOn": ["type-utils:build"],
       "executor": "nx:run-script",
       "options": {
-        "script": "generate:breaking-changes"
+        "script": "generate-breaking-changes"
       }
     }
   }

diff --git a/packages/eslint-plugin/tests/index.test.ts b/packages/eslint-plugin/tests/index.test.ts
@@ -9,12 +9,16 @@ describe('eslint-plugin ("./src/index.ts")', () => {
   const eslintPluginRuleKeys = Object.keys(eslintPlugin.rules);
 
   const eslintrcConfigs = fs
-    .readdirSync('./src/configs/eslintrc')
+    .readdirSync(path.join(__dirname, '..', 'src', 'configs', 'eslintrc'), {
+      encoding: 'utf-8',
+    })
     .filter(file => ['.json', '.ts'].includes(path.extname(file).toLowerCase()))
     .map(file => path.basename(file, path.extname(file)));
 
   const flatConfigs = fs
-    .readdirSync('./src/configs/flat')
+    .readdirSync(path.join(__dirname, '..', 'src', 'configs', 'flat'), {
+      encoding: 'utf-8',
+    })
     .filter(file => ['.json', '.ts'].includes(path.extname(file).toLowerCase()))
     .map(file => path.basename(file, path.extname(file)))
     .map(file => `flat/${file}`);

diff --git a/packages/eslint-plugin/tests/rules/index.test.ts b/packages/eslint-plugin/tests/rules/index.test.ts
@@ -1,4 +1,5 @@
 import fs from 'node:fs';
+import * as path from 'node:path';
 
 import rules from '../../src/rules';
 
@@ -7,7 +8,7 @@ describe('./src/rules/index.ts', () => {
     .map(name => `${name}.ts`)
     .sort();
   const files = fs
-    .readdirSync('./src/rules')
+    .readdirSync(path.join(__dirname, '..', '..', 'src', 'rules'))
     .filter(file => file !== 'index.ts' && file.endsWith('.ts'));
 
   it('imports all available rule modules', () => {