Skip to content

chore(type-utils): migrate from jest to vitest #10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Apr 14, 2025
Merged

chore(type-utils): migrate from jest to vitest #10767

merged 43 commits into from
Apr 14, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 3, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7d7d5b2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fa1cf539344e0008d9cb9b
😎 Deploy Preview https://deploy-preview-10767--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 83 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@aryaemami59 aryaemami59 marked this pull request as ready for review February 3, 2025 18:12
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 7d7d5b2.

Command Status Duration Result
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 18s View ↗
nx test eslint-plugin ✅ Succeeded 7m 39s View ↗
nx test type-utils ✅ Succeeded 23s View ↗
nx test utils ✅ Succeeded 13s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx typecheck ast-spec ✅ Succeeded 4s View ↗
nx test parser ✅ Succeeded 6s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1m 12s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-12 08:18:42 UTC

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 3, 2025

View your CI Pipeline Execution ↗ for commit 2bb6cd0.

Command Status Duration Result
nx run-many --target=clean ✅ Succeeded 12s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 58s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-03 18:17:43 UTC

@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (0f9b55d) to head (7d7d5b2).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10767      +/-   ##
==========================================
+ Coverage   87.68%   88.16%   +0.48%     
==========================================
  Files         486      497      +11     
  Lines       15910    17830    +1920     
  Branches     4602     4798     +196     
==========================================
+ Hits        13950    15720    +1770     
- Misses       1615     1775     +160     
+ Partials      345      335      -10
Flag Coverage Δ
unittest 88.16% <ø> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/type-utils-vitest-migration branch 23 times, most recently from a95be7e to fb8411e Compare February 10, 2025 17:49
@aryaemami59 aryaemami59 force-pushed the chore/type-utils-vitest-migration branch from fb8411e to 25485c6 Compare February 12, 2025 13:44
@aryaemami59 aryaemami59 force-pushed the chore/type-utils-vitest-migration branch from 1b7c9b1 to 777707e Compare April 5, 2025 13:32
aryaemami59 added 11 commits April 7, 2025 07:06
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
dbd6f2a 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
b9e58ef 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
f8fc004 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Update vite to version 6.2.6
99133cd
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.40
e71694d
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
edad3d2 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
19fa3da 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.42
d938588
@aryaemami59
Enable the new vitest/prefer-describe-function-title rule
b270084
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
71798a3 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Use vitestPlugin.configs.env
14f14e2
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 28, 2025
Closed
14 tasks
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
1658bcd 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
945f599 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
03a7cf4 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Run ast-spec:typecheck during postinstall
60b6c60
@aryaemami59
Fix ast-spec:test
bddd2be
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
a1e534f 
…t-eslint into chore/type-utils-vitest-migration
@aryaemami59
Fix ast-spec:build
d57f66b
@aryaemami59
Try disabling remote cache
d4f77e9
@aryaemami59
Try disabling remote cache
7137af9
@aryaemami59
Update typecheck output path in nx.json
971aec3
@aryaemami59
Set testTimeout to 10_000
b40e037
@aryaemami59
Switch to it.for
7af2d6f
@aryaemami59
Fix vitest coverage output when run with nx
7d7d5b2
@JoshuaKGoldberg JoshuaKGoldberg merged commit 431ad44 into typescript-eslint:main Apr 14, 2025
56 of 57 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
@aryaemami59 aryaemami59 deleted the chore/type-utils-vitest-migration branch April 23, 2025 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @kirkwaiblinger