Skip to content

chore(ast-spec): migrate from jest to vitest #10770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Apr 14, 2025
Merged

chore(ast-spec): migrate from jest to vitest #10770

merged 44 commits into from
Apr 14, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a7d6829.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 6m 19s View ↗
nx test typescript-eslint ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx typecheck ast-spec ✅ Succeeded 5s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1m 13s View ↗
nx test typescript-estree ✅ Succeeded 43s View ↗
nx test type-utils ✅ Succeeded 24s View ↗
nx test utils ✅ Succeeded 12s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 15:10:05 UTC

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2025

View your CI Pipeline Execution ↗ for commit 927780b.

Command Status Duration Result
nx run typescript-eslint:test ✅ Succeeded 5s View ↗
nx run parser:test ✅ Succeeded 8s View ↗
nx run scope-manager:test ✅ Succeeded 8s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 57s View ↗
nx run eslint-plugin-internal:test ✅ Succeeded 9s View ↗
nx run ast-spec:test ✅ Succeeded 7s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded <1s View ↗
nx run utils:test ✅ Succeeded 4s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-04 06:46:42 UTC

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a7d6829
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fd1f13c5fc79000885bc15
😎 Deploy Preview https://deploy-preview-10770--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@aryaemami59 aryaemami59 force-pushed the chore/ast-spec-vitest-migration branch 2 times, most recently from 157cb3c to c1cdacd Compare February 4, 2025 07:15
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (e8ea7a4) to head (a7d6829).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10770      +/-   ##
==========================================
- Coverage   88.91%   84.31%   -4.60%     
==========================================
  Files         496      497       +1     
  Lines       23713    27766    +4053     
  Branches     4896     5075     +179     
==========================================
+ Hits        21084    23411    +2327     
- Misses       2356     4184    +1828     
+ Partials      273      171     -102
Flag Coverage Δ
unittest 84.31% <ø> (-4.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 changed the title chore(eslint-plugin-internal): migrate from jest to vitest chore(ast-spec): migrate from jest to vitest Feb 4, 2025
@aryaemami59 aryaemami59 force-pushed the chore/ast-spec-vitest-migration branch 22 times, most recently from 60179cc to 9347ac0 Compare February 10, 2025 16:34
@aryaemami59 aryaemami59 force-pushed the chore/ast-spec-vitest-migration branch from ce330a2 to c12400d Compare April 5, 2025 13:58
aryaemami59 added 14 commits April 7, 2025 07:00
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
dc5f36f 
…t-eslint into chore/ast-spec-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
a3ebf6e 
…t-eslint into chore/ast-spec-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
ce0086f 
…t-eslint into chore/ast-spec-vitest-migration
@aryaemami59
Update vite to version 6.2.6
67b51bb
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.40
87473f4
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
10f0c75 
…t-eslint into chore/ast-spec-vitest-migration
@aryaemami59
Fix ast-spec tests
50a4872
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
1c4a510 
…t-eslint into chore/ast-spec-vitest-migration
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.42
16dfec0
@aryaemami59
Enable the new vitest/prefer-describe-function-title rule
6b8688c
@aryaemami59
Use vitestPlugin.configs.env
d0959a6
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
59dac25 
…t-eslint into chore/ast-spec-vitest-migration
@aryaemami59
Fix ast-spec tests
af05c64
@aryaemami59
Include test setupFiles in ESLint config
302b66d
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 28, 2025
Closed
14 tasks
@JoshuaKGoldberg JoshuaKGoldberg merged commit c0caaf1 into typescript-eslint:main Apr 14, 2025
54 of 55 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
@aryaemami59 aryaemami59 deleted the chore/ast-spec-vitest-migration branch April 23, 2025 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaemami59 @JoshuaKGoldberg