Skip to content

chore(typescript-eslint): migrate from jest to vitest #10772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8479c64
Install `vitest`
aryaemami59 Feb 3, 2025
e66a225
Rename `jest.config.js` to `vitest.config.mts`
aryaemami59 Feb 3, 2025
c5e83a5
chore(typescript-eslint): migrate to `vitest`
aryaemami59 Feb 3, 2025
691a3ca
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
aryaemami59 Mar 7, 2025
3609bed
Update `vitest` to version 3.0.8
aryaemami59 Mar 7, 2025
65238e0
Remove `vitest/no-done-callback` as it is deprecated.
aryaemami59 Mar 7, 2025
1ed63ff
Fix Vitest config
aryaemami59 Mar 7, 2025
fc07af1
Include `vitest.config.mts` in `tsconfig.spec.json`
aryaemami59 Mar 8, 2025
69caafb
Add `vitest.config.mts` files to ESLint configuration
aryaemami59 Mar 8, 2025
ca31d4e
Use `defineProject` instead of `defineConfig`
aryaemami59 Mar 10, 2025
19ebf4b
Simplify `workspace` and `coverage.exclude`
aryaemami59 Mar 10, 2025
56b2de3
Explicitly enable `resolveJsonModule`
aryaemami59 Mar 10, 2025
de160a3
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
aryaemami59 Mar 10, 2025
bb28ba4
Type check `vitest.config.mts` files using project references.
aryaemami59 Mar 10, 2025
04eea20
Fix `@nx/vite/plugin` usage in `nx.json`
aryaemami59 Mar 10, 2025
08bb1a8
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
aryaemami59 Mar 10, 2025
0e75892
Update `@vitest/eslint-plugin` to version 1.1.37
aryaemami59 Mar 11, 2025
61f27d1
Fix Vitest config
aryaemami59 Mar 12, 2025
0bc9868
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
aryaemami59 Mar 12, 2025
ec10987
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
aryaemami59 Mar 15, 2025
273e62a
Update `vite` to version 6.2.2
aryaemami59 Mar 15, 2025
554e60c
Fix `typecheck` task
aryaemami59 Mar 16, 2025
f1e0834
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
aryaemami59 Mar 22, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const restrictNamedDeclarations = {

const vitestFiles = [
'packages/eslint-plugin-internal/tests/**/*.test.{ts,tsx,cts,mts}',
'packages/typescript-eslint/tests/**/*.test.{ts,tsx,cts,mts}',
];

export default tseslint.config(
Expand Down
8 changes: 0 additions & 8 deletions packages/typescript-eslint/jest.config.js

This file was deleted.

10 changes: 5 additions & 5 deletions packages/typescript-eslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage",
"postclean": "rimraf dist/ _ts4.3/ coverage/",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"lint": "nx lint",
"test": "jest --passWithNoTests",
"test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
"check-types": "npx nx typecheck"
},
"dependencies": {
Expand All @@ -62,12 +62,12 @@
"typescript": ">=4.8.4 <5.9.0"
},
"devDependencies": {
"@jest/types": "29.6.3",
"@vitest/coverage-v8": "^3.0.8",
"downlevel-dts": "*",
"jest": "29.7.0",
"prettier": "^3.2.5",
"rimraf": "*",
"typescript": "*"
"typescript": "*",
"vitest": "^3.0.8"
},
"funding": {
"type": "opencollective",
Expand Down
8 changes: 6 additions & 2 deletions packages/typescript-eslint/project.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"name": "typescript-eslint",
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"type": "library",
"implicitDependencies": [],
"projectType": "library",
"root": "packages/typescript-eslint",
"sourceRoot": "packages/typescript-eslint/src",
"targets": {
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
},
"test": {
"executor": "@nx/vite:test"
}
}
}
2 changes: 1 addition & 1 deletion packages/typescript-eslint/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"types": ["node"]
},
"include": ["src/**/*.ts"],
"exclude": ["jest.config.js", "src/**/*.spec.ts", "src/**/*.test.ts"],
"exclude": ["vitest.config.mts", "src/**/*.spec.ts", "src/**/*.test.ts"],
"references": [
{
"path": "../utils/tsconfig.build.json"
Expand Down
9 changes: 7 additions & 2 deletions packages/typescript-eslint/tsconfig.spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"compilerOptions": {
"outDir": "../../dist/out-tsc/packages/typescript-eslint",
"module": "NodeNext",
"types": ["jest", "node"]
"resolveJsonModule": true,
"types": ["node", "vitest/globals", "vitest/importMeta"]
},
"include": [
"jest.config.js",
"vitest.config.mts",
"package.json",
"src/**/*.test.ts",
"src/**/*.spec.ts",
"src/**/*.d.ts",
Expand All @@ -16,6 +18,9 @@
"references": [
{
"path": "./tsconfig.build.json"
},
{
"path": "../../tsconfig.spec.json"
}
]
}
21 changes: 21 additions & 0 deletions packages/typescript-eslint/vitest.config.mts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import * as path from 'node:path';
import { defineProject, mergeConfig } from 'vitest/config';

import { vitestBaseConfig } from '../../vitest.config.base.mjs';
import packageJson from './package.json' with { type: 'json' };

const vitestConfig = mergeConfig(
vitestBaseConfig,

defineProject({
root: import.meta.dirname,

test: {
dir: path.join(import.meta.dirname, 'tests'),
name: packageJson.name,
root: import.meta.dirname,
},
}),
);

export default vitestConfig;
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -20428,15 +20428,15 @@ __metadata:
version: 0.0.0-use.local
resolution: "typescript-eslint@workspace:packages/typescript-eslint"
dependencies:
"@jest/types": 29.6.3
"@typescript-eslint/eslint-plugin": 8.27.0
"@typescript-eslint/parser": 8.27.0
"@typescript-eslint/utils": 8.27.0
"@vitest/coverage-v8": ^3.0.8
downlevel-dts: "*"
jest: 29.7.0
prettier: ^3.2.5
rimraf: "*"
typescript: "*"
vitest: ^3.0.8
peerDependencies:
eslint: ^8.57.0 || ^9.0.0
typescript: ">=4.8.4 <5.9.0"
Expand Down
Loading