typescript-eslint · JoshuaKGoldberg · Apr 10, 2025 · Feb 4, 2025 · Feb 4, 2025 · Feb 4, 2025
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -32,6 +32,7 @@ const restrictNamedDeclarations = {
 const vitestFiles = [
   'packages/eslint-plugin-internal/tests/**/*.test.{ts,tsx,cts,mts}',
   'packages/typescript-eslint/tests/**/*.test.{ts,tsx,cts,mts}',
+  'packages/visitor-keys/tests/**/*.test.{ts,tsx,cts,mts}',
 ];
 
 export default tseslint.config(

diff --git a/knip.ts b/knip.ts
@@ -11,9 +11,14 @@ export default {
     types: 'off',
     unresolved: 'off',
   },
+
+  vite: false,
+
   vitest: {
-    config: ['vitest.config.mts', 'packages/*/vitest.config.mts'],
+    config: ['vitest.config.mts'],
+    entry: ['tests/**/*.{bench,test,test-d}.?(c|m)ts?(x)'],
   },
+
   workspaces: {
     '.': {
       entry: ['tools/release/changelog-renderer.js', 'tools/scripts/**/*.mts'],

diff --git a/package.json b/package.json
@@ -89,8 +89,8 @@
     "@typescript-eslint/types": "workspace:^",
     "@typescript-eslint/typescript-estree": "workspace:^",
     "@typescript-eslint/utils": "workspace:^",
-    "@vitest/coverage-v8": "^3.0.8",
-    "@vitest/eslint-plugin": "^1.1.37",
+    "@vitest/coverage-v8": "^3.1.1",
+    "@vitest/eslint-plugin": "^1.1.39",
     "console-fail-test": "^0.5.0",
     "cross-fetch": "^4.0.0",
     "cspell": "^8.15.2",
@@ -126,8 +126,8 @@
     "tsx": "*",
     "typescript": ">=4.8.4 <5.9.0",
     "typescript-eslint": "workspace:^",
-    "vite": "^6.2.2",
-    "vitest": "^3.0.8",
+    "vite": "^6.2.5",
+    "vitest": "^3.1.1",
     "yargs": "17.7.2"
   },
   "resolutions": {

diff --git a/packages/eslint-plugin-internal/package.json b/packages/eslint-plugin-internal/package.json
@@ -31,8 +31,8 @@
     "prettier": "^3.2.5"
   },
   "devDependencies": {
-    "@vitest/coverage-v8": "^3.0.8",
+    "@vitest/coverage-v8": "^3.1.1",
     "rimraf": "*",
-    "vitest": "^3.0.8"
+    "vitest": "^3.1.1"
   }
 }
diff --git a/packages/typescript-eslint/package.json b/packages/typescript-eslint/package.json
@@ -62,12 +62,12 @@
     "typescript": ">=4.8.4 <5.9.0"
   },
   "devDependencies": {
-    "@vitest/coverage-v8": "^3.0.8",
+    "@vitest/coverage-v8": "^3.1.1",
     "downlevel-dts": "*",
     "prettier": "^3.2.5",
     "rimraf": "*",
     "typescript": "*",
-    "vitest": "^3.0.8"
+    "vitest": "^3.1.1"
   },
   "funding": {
     "type": "opencollective",

diff --git a/packages/visitor-keys/jest.config.js b/packages/visitor-keys/jest.config.js
diff --git a/packages/visitor-keys/package.json b/packages/visitor-keys/package.json
@@ -41,23 +41,23 @@
     "build": "tsc -b tsconfig.build.json",
     "postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
     "clean": "tsc -b tsconfig.build.json --clean",
-    "postclean": "rimraf dist && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
+    "postclean": "rimraf dist/ _ts4.3/ coverage/",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest",
+    "test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
     "check-types": "npx nx typecheck"
   },
   "dependencies": {
     "@typescript-eslint/types": "8.29.1",
     "eslint-visitor-keys": "^4.2.0"
   },
   "devDependencies": {
-    "@jest/types": "29.6.3",
+    "@vitest/coverage-v8": "^3.1.1",
     "downlevel-dts": "*",
-    "jest": "29.7.0",
     "prettier": "^3.2.5",
     "rimraf": "*",
-    "typescript": "*"
+    "typescript": "*",
+    "vitest": "^3.1.1"
   },
   "funding": {
     "type": "opencollective",

diff --git a/packages/visitor-keys/project.json b/packages/visitor-keys/project.json
@@ -1,12 +1,16 @@
 {
   "name": "visitor-keys",
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
-  "type": "library",
-  "implicitDependencies": [],
+  "projectType": "library",
+  "root": "packages/visitor-keys",
+  "sourceRoot": "packages/visitor-keys/src",
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
       "outputs": ["{options.outputFile}"]
+    },
+    "test": {
+      "executor": "@nx/vite:test"
     }
   }
 }
diff --git a/packages/visitor-keys/tests/visitor-keys.test.ts b/packages/visitor-keys/tests/visitor-keys.test.ts
@@ -6,31 +6,21 @@ const types = new Set(Object.keys(AST_NODE_TYPES));
 const keys = new Set(Object.keys(visitorKeys));
 
 describe('Every ast node type should have a visitor key defined', () => {
-  for (const type of types) {
-    it(type, () => {
-      expect(keys.has(type)).toBeTruthy();
-    });
-  }
+  it.for([...types])('%s', (type, { expect }) => {
+    expect(keys).toContain(type);
+  });
 });
 
 // these keys are defined by the base eslint module, and are not covered by our AST
 const IGNORED_KEYS = new Set([
   'ExperimentalRestProperty',
   'ExperimentalSpreadProperty',
 ]);
-describe('Every visitor key should have an ast node type defined', () => {
-  for (const key of keys) {
-    if (IGNORED_KEYS.has(key)) {
-      if (types.has(key)) {
-        it(`${key} should not be ignored as it has an AST_NODE_TYPE defined`, () => {
-          expect(true).toBeFalsy();
-        });
-      }
-      continue;
-    }
 
-    it(key, () => {
-      expect(types.has(key)).toBeTruthy();
-    });
-  }
+const nonIgnoredKeys = [...keys].filter(key => !IGNORED_KEYS.has(key));
+
+describe('Every visitor key should have an ast node type defined', () => {
+  it.for(nonIgnoredKeys)('%s', (key, { expect }) => {
+    expect(types).toContain(key);
+  });
 });
diff --git a/packages/visitor-keys/tsconfig.build.json b/packages/visitor-keys/tsconfig.build.json
@@ -9,7 +9,7 @@
     "types": ["node"]
   },
   "include": ["src/**/*.ts"],
-  "exclude": ["jest.config.js", "src/**/*.spec.ts", "src/**/*.test.ts"],
+  "exclude": ["vitest.config.mts", "src/**/*.spec.ts", "src/**/*.test.ts"],
   "references": [
     {
       "path": "../types/tsconfig.build.json"

diff --git a/packages/visitor-keys/tsconfig.spec.json b/packages/visitor-keys/tsconfig.spec.json
@@ -3,10 +3,12 @@
   "compilerOptions": {
     "outDir": "../../dist/out-tsc/packages/visitor-keys",
     "module": "NodeNext",
-    "types": ["jest", "node"]
+    "resolveJsonModule": true,
+    "types": ["node", "vitest/globals", "vitest/importMeta"]
   },
   "include": [
-    "jest.config.js",
+    "vitest.config.mts",
+    "package.json",
     "src/**/*.test.ts",
     "src/**/*.spec.ts",
     "src/**/*.d.ts",
@@ -15,6 +17,9 @@
   "references": [
     {
       "path": "./tsconfig.build.json"
+    },
+    {
+      "path": "../../tsconfig.spec.json"
     }
   ]
 }
diff --git a/packages/visitor-keys/vitest.config.mts b/packages/visitor-keys/vitest.config.mts
@@ -0,0 +1,21 @@
+import * as path from 'node:path';
+import { defineProject, mergeConfig } from 'vitest/config';
+
+import { vitestBaseConfig } from '../../vitest.config.base.mjs';
+import packageJson from './package.json' with { type: 'json' };
+
+const vitestConfig = mergeConfig(
+  vitestBaseConfig,
+
+  defineProject({
+    root: import.meta.dirname,
+
+    test: {
+      dir: path.join(import.meta.dirname, 'tests'),
+      name: packageJson.name.replace('@typescript-eslint/', ''),
+      root: import.meta.dirname,
+    },
+  }),
+);
+
+export default vitestConfig;