Skip to content

chore(parser): migrate from jest to vitest #10775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Apr 11, 2025
Merged

chore(parser): migrate from jest to vitest #10775

merged 33 commits into from
Apr 11, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit eae45b1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67f8ad29e293cc0008b4367c
😎 Deploy Preview https://deploy-preview-10775--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit eae45b1.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-11 06:06:26 UTC

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (7f23300) to head (eae45b1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10775   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         497      497           
  Lines       17029    17029           
  Branches     4747     4747           
=======================================
  Hits        15017    15017           
  Misses       1666     1666           
  Partials      346      346
Flag Coverage Δ
unittest 88.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/parser-vitest-migration branch 18 times, most recently from e4558be to ec7c8fe Compare February 10, 2025 17:42
@aryaemami59 aryaemami59 force-pushed the chore/parser-vitest-migration branch 7 times, most recently from 976e22a to 2898891 Compare February 15, 2025 12:10
@JoshuaKGoldberg
Copy link
Member

Marking as blocked on #10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages.

@aryaemami59 aryaemami59 force-pushed the chore/parser-vitest-migration branch from f4ddbe9 to 94daf56 Compare April 5, 2025 08:24
@43081j
Copy link
Contributor

43081j commented Apr 7, 2025

one minor comment but otherwise looks good to me 👍

aryaemami59 added 12 commits April 7, 2025 11:08
@aryaemami59
Fix ESLint config
602bd41
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
091ca59 
…t-eslint into chore/parser-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
9927f4d 
…t-eslint into chore/parser-vitest-migration
@aryaemami59
Update vite to version 6.2.6
c2cf955
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.40
7eb7099
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
ec7ea6d 
…t-eslint into chore/parser-vitest-migration
@aryaemami59
Fix parser tests
8a430b4
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.42
7da9605
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
2a78738 
…t-eslint into chore/parser-vitest-migration
@aryaemami59
Enable the new vitest/prefer-describe-function-title rule
d90fde4
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
fe66cfd 
…t-eslint into chore/parser-vitest-migration
@aryaemami59
Use vitestPlugin.configs.env
eae45b1
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@JoshuaKGoldberg JoshuaKGoldberg merged commit c438c50 into typescript-eslint:main Apr 11, 2025
58 of 59 checks passed
@aryaemami59 aryaemami59 deleted the chore/parser-vitest-migration branch April 11, 2025 14:39
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 28, 2025
Closed
14 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@43081j 43081j 43081j left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @43081j