Skip to content

chore: migrate integration-tests from jest to vitest #10778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b770af7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fd0447bfcc0400085ced79
😎 Deploy Preview https://deploy-preview-10778--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Feb 4, 2025

View your CI Pipeline Execution ↗ for commit b770af7.

Command Status Duration Result
nx test eslint-plugin-internal --coverage=false ❌ Failed 7s View ↗
nx test typescript-estree ✅ Succeeded 1m 17s View ↗
nx test eslint-plugin ✅ Succeeded 6m 30s View ↗
nx test scope-manager ✅ Succeeded 15s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test parser ✅ Succeeded 9s View ↗
nx typecheck ast-spec ✅ Succeeded 4s View ↗
nx test type-utils ✅ Succeeded 23s View ↗
Additional runs (23) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 13:13:00 UTC

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (6e03f7c) to head (b770af7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10778   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files         497      497           
  Lines       17840    17840           
  Branches     4803     4803           
=======================================
  Hits        15730    15730           
  Misses       1775     1775           
  Partials      335      335           
Flag Coverage Δ
unittest 88.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/integration-tests-vitest-migration branch 3 times, most recently from f4928c9 to d1ae6bd Compare February 5, 2025 06:49
@aryaemami59 aryaemami59 changed the title chore(integration-tests): migrate from jest to vitest chore: migrate integration-tests from jest to vitest Feb 5, 2025
@aryaemami59 aryaemami59 force-pushed the chore/integration-tests-vitest-migration branch 17 times, most recently from e4a4edc to 7ee35e2 Compare February 10, 2025 17:38
@aryaemami59 aryaemami59 force-pushed the chore/integration-tests-vitest-migration branch 5 times, most recently from b0b2e75 to 57ea6b2 Compare February 14, 2025 13:56
@JoshuaKGoldberg JoshuaKGoldberg merged commit 40aa2ab into typescript-eslint:main Apr 14, 2025
48 of 53 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
@aryaemami59 aryaemami59 deleted the chore/integration-tests-vitest-migration branch April 23, 2025 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants