Skip to content

fix(eslint-plugin): [no-inferrable-types] handle accessor #10780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2025
Merged

fix(eslint-plugin): [no-inferrable-types] handle accessor #10780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a59e6a7
fix(eslint-plugin): [no-inferrable-types] handle accessor
yeonjuan Feb 4, 2025
1e0affa
apply reviews
yeonjuan Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/eslint-plugin/src/rules/no-inferrable-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ export default createRule<Options, MessageIds>({
*/
function reportInferrableType(
node:
| TSESTree.AccessorProperty
| TSESTree.Parameter
| TSESTree.PropertyDefinition
| TSESTree.VariableDeclarator,
Expand Down Expand Up @@ -265,7 +266,7 @@ export default createRule<Options, MessageIds>({
}

function inferrablePropertyVisitor(
node: TSESTree.PropertyDefinition,
node: TSESTree.AccessorProperty | TSESTree.PropertyDefinition,
): void {
// We ignore `readonly` because of Microsoft/TypeScript#14416
// Essentially a readonly property without a type
Expand All @@ -278,6 +279,7 @@ export default createRule<Options, MessageIds>({
}

return {
AccessorProperty: inferrablePropertyVisitor,
ArrowFunctionExpression: inferrableParameterVisitor,
FunctionDeclaration: inferrableParameterVisitor,
FunctionExpression: inferrableParameterVisitor,
Expand Down
35 changes: 35 additions & 0 deletions packages/eslint-plugin/tests/rules/no-inferrable-types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ class Foo {
readonly a: number = 5;
}
`,
`
class Foo {
accessor a = 5;
}
`,

'const a: any = 5;',
"const fn = function (a: any = 5, b: any = true, c: any = 'foo') {};",
Expand Down Expand Up @@ -141,6 +146,14 @@ class Foo {
},
{
code: `
class Foo {
accessor a: number = 5;
}
`,
options: [{ ignoreProperties: true }],
},
{
code: `
class Foo {
a?: number = 5;
b?: boolean = true;
Expand Down Expand Up @@ -316,6 +329,28 @@ class Foo {
output: `
class Foo {
constructor(public a = true) {}
}
`,
},
{
code: `
class Foo {
accessor a: number = 5;
}
`,
errors: [
{
column: 3,
data: {
type: 'number',
},
line: 3,
messageId: 'noInferrableType',
},
],
output: `
class Foo {
accessor a = 5;
}
`,
},
Expand Down
Loading