Skip to content

feat(typescript-eslint): export util types (close #10848) #10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(typescript-eslint): export util types (close #10848) #10849

wants to merge 1 commit into from

Conversation

Mister-Hope
Copy link
Contributor

@Mister-Hope Mister-Hope commented Feb 19, 2025 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

This adds export for a namespace TSLint which contain types used in tslint.

The main reason is that as the documentation suggests using tslint stricter types: https://typescript-eslint.io/getting-started#step-2-configuration, people may need to implicitly mark codes to these types in their own flag config, as auto-infer may contain "loose types" (e.g.: string instead of 'a' | 'b') that triggers ts errors.

For examples,see #10848

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Mister-Hope!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e13eb6a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67b567c84c909c0008c987bd
😎 Deploy Preview https://deploy-preview-10849--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🟢 up 20 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 19, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e13eb6a.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 5s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-19 05:19:12 UTC

@JoshuaKGoldberg
Copy link
Member

Switching this PR to draft pending issue triage.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft February 19, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: export types in typescript-eslint package
2 participants
@Mister-Hope @JoshuaKGoldberg