Skip to content

fix(eslint-plugin): [no-unnecessary-type-assertion] handle unknown #10875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2025
Merged

fix(eslint-plugin): [no-unnecessary-type-assertion] handle unknown #10875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c36201
fix(eslint-plugin): [no-unnecessary-type-assertion] handle unknown
yeonjuan Feb 24, 2025
437b7f9
fix format
yeonjuan Feb 24, 2025
ec30ac7
Merge branch 'main' into fixes/10831
yeonjuan Feb 25, 2025
665c762
Merge branch 'main' into fixes/10831
yeonjuan Feb 28, 2025
f610080
apply reviews
yeonjuan Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,13 @@ export default createRule<Options, MessageIds>({

const contextualType = getContextualType(checker, originalNode);
if (contextualType) {
if (
isTypeFlagSet(type, ts.TypeFlags.Unknown) &&
!isTypeFlagSet(contextualType, ts.TypeFlags.Unknown)
) {
return;
}

// in strict mode you can't assign null to undefined, so we have to make sure that
// the two types share a nullable type
const typeIncludesUndefined = isTypeFlagSet(
Expand Down
45 changes: 45 additions & 0 deletions packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,19 @@ enum T {
const b = 1 as T.Value2;
`,
},
`
const foo: unknown = {};
const baz: {} = foo!;
`,
`
const foo: unknown = {};
const bar: object = foo!;
`,
`
declare function foo<T extends unknown>(bar: T): T;
const baz: unknown = {};
foo(baz!);
`,
],

invalid: [
Expand Down Expand Up @@ -1335,5 +1348,37 @@ declare const a: T.Value1;
const b = a;
`,
},
{
code: `
const foo: unknown = {};
const bar: unknown = foo!;
`,
errors: [
{
messageId: 'contextuallyUnnecessary',
},
],
output: `
const foo: unknown = {};
const bar: unknown = foo;
`,
},
{
code: `
function foo(bar: unknown) {}
const baz: unknown = {};
foo(baz!);
`,
errors: [
{
messageId: 'contextuallyUnnecessary',
},
],
output: `
function foo(bar: unknown) {}
const baz: unknown = {};
foo(baz);
`,
},
],
});