Skip to content

chore: remove unused scripts #10886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

chore: remove unused scripts #10886

merged 2 commits into from
Feb 27, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Feb 25, 2025 •
edited
Loading

Removes a couple of unused/broken scripts from
rule-schema-to-typescript-types.

Also adds a missing nx target such that generate-breaking-changes works again.

PR Checklist

@43081j
cleanup(repo): remove unused scripts
eef7c30 
Removes a couple of unused/broken scripts from
`rule-schema-to-typescript-types`.

Also adds a missing nx target such that `generate-breaking-changes`
works again.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6774f10
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67c0d20812b1d80008b53c6c
😎 Deploy Preview https://deploy-preview-10886--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 79 (🔴 down 19 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6774f10.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 7m 39s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 1s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6m 21s View ↗
nx test visitor-keys ✅ Succeeded <1s View ↗
nx test type-utils ✅ Succeeded <1s View ↗
nx test utils ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test typescript-estree ✅ Succeeded <1s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-27 21:13:39 UTC

@43081j 43081j changed the title cleanup(repo): remove unused scripts chore(repo): remove unused scripts Feb 25, 2025
@43081j 43081j changed the title chore(repo): remove unused scripts chore: remove unused scripts Feb 25, 2025
This was referenced Feb 25, 2025
Merged
Closed
kirkwaiblinger
kirkwaiblinger approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the cleanup!

@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) February 27, 2025 20:58
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (83da0b8) to head (6774f10).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10886   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         468      468           
  Lines       16027    16027           
  Branches     4640     4640           
=======================================
  Hits        14013    14013           
  Misses       1658     1658           
  Partials      356      356
Flag Coverage Δ
unittest 87.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kirkwaiblinger kirkwaiblinger merged commit 89f0c61 into typescript-eslint:main Feb 27, 2025
88 of 89 checks passed
@43081j 43081j deleted the nodets-script-prep branch February 27, 2025 21:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@43081j @kirkwaiblinger