chore: drop tsx for node strip-types #10888
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a couple of unused/broken scripts from `rule-schema-to-typescript-types`. Also adds a missing nx target such that `generate-breaking-changes` works again.
This switches various repo scripts to be `*.mts` files (since that is what they actually are, given we don't build them into CJS output, yet our package `type` is `"commonjs"`). This will allow newer Node to execute them correctly, as they will now infer the correct module type. The `generate-lib` script has also been changed to use only strippable types (i.e. no enums). Both of these changes mean we have the option to drop `tsx` in future and use `--experimental-strip-types` (when it is no longer experimental).
Drops `tsx` and uses `--experimental-strip-types` to directly execute the various typescript scripts we have. We likely don't want to land this until it is no longer "experimental".
|
Thanks for the PR, @43081j! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
❌ Deploy Preview for typescript-eslint failed.
|
|
View your CI Pipeline Execution ↗ for commit c149688.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from
tsxto--experimental-strip-typesDRAFT UNTIL FURTHER NOTICE
It is here to make sure people don't open duplicate PRs, but we can't land it yet since it requires too late a version of node.
Our CI is still using old enough node that this flag doesn't exist (plus it is "experimental" after all).
PR Checklist