fix(eslint-plugin): [no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary #10907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @y-hsgw! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View your CI Pipeline Execution ↗ for commit 30b0c4f.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10907 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 497 497
Lines 50259 50279 +20
Branches 8291 8297 +6
=======================================
+ Hits 45652 45672 +20
Misses 4592 4592
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Wait, was too optimistic - taking a closer look..
JoshuaKGoldberg
requested changes
Mar 10, 2025
packages/eslint-plugin/src/rules/no-unnecessary-type-parameters.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/no-unnecessary-type-parameters.test.ts
Outdated
Show resolved
Hide resolved
JoshuaKGoldberg
previously approved these changes
Mar 17, 2025
kirkwaiblinger
requested changes
Mar 19, 2025
packages/eslint-plugin/src/rules/no-unnecessary-type-parameters.ts
Outdated
Show resolved
Hide resolved
JoshuaKGoldberg
previously approved these changes
Mar 31, 2025
There was a problem hiding this comment.
👍 will defer to @kirkwaiblinger, as they caught things I didn't last time. LGTM otherwise!
|
Sorry for the delay! |
kirkwaiblinger
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Fixed the bug described in the title.
Please note that in addition to the error examples in the #10894, I have also addressed several related cases.
🐛