Skip to content

feat(utils): support DeprecatedInfo for rule.meta.deprecated #10932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

feat(utils): support DeprecatedInfo for rule.meta.deprecated #10932

merged 3 commits into from
Mar 17, 2025

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Mar 10, 2025

PR Checklist

Overview

This PR does:

  • Add type DeprecatedInfo support to field Rule.meta.deprecated
  • Deprecated filed Rule.meta.replacedBy
  • Add basic deprecated info to deprecated rules

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ntnyq!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6040519
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67cfb072cf26620008da8778
😎 Deploy Preview https://deploy-preview-10932--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Mar 10, 2025

View your CI Pipeline Execution ↗ for commit 6040519.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-11 11:33:38 UTC

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (9aa0b6b) to head (6040519).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10932   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files         470      470           
  Lines       16095    16095           
  Branches     4668     4668           
=======================================
  Hits        14097    14097           
  Misses       1642     1642           
  Partials      356      356           
Flag Coverage Δ
unittest 87.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ages/eslint-plugin/src/rules/no-empty-interface.ts 100.00% <ø> (ø)
...es/eslint-plugin/src/rules/no-loss-of-precision.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts 100.00% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-var-requires.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/prefer-ts-expect-error.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/sort-type-constituents.ts 94.82% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks great to me, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 11, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 342d98e into typescript-eslint:main Mar 17, 2025
59 of 60 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 21, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.26.0 | 8.27.0 |
| npm        | @typescript-eslint/parser        | 8.26.0 | 8.27.0 |


## [v8.27.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8270-2025-03-17)

##### 🚀 Features

-   **utils:** support `DeprecatedInfo` for `rule.meta.deprecated` ([#10932](typescript-eslint/typescript-eslint#10932))

##### ❤️ Thank You

-   ntnyq [@ntnyq](https://github.com/ntnyq)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.


## [v8.26.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8261-2025-03-10)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unsafe-return] handle recursive type ([#10883](typescript-eslint/typescript-eslint#10883))
-   **eslint-plugin:** \[prefer-nullish-coalescing] treat `any`/`unknown` as eligible for nullish coalescing ([#10865](typescript-eslint/typescript-eslint#10865))

##### ❤️ Thank You

-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 21, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.26.0 | 8.27.0 |
| npm        | @typescript-eslint/parser        | 8.26.0 | 8.27.0 |


## [v8.27.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8270-2025-03-17)

##### 🚀 Features

-   **utils:** support `DeprecatedInfo` for `rule.meta.deprecated` ([#10932](typescript-eslint/typescript-eslint#10932))

##### ❤️ Thank You

-   ntnyq [@ntnyq](https://github.com/ntnyq)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.


## [v8.26.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8261-2025-03-10)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unsafe-return] handle recursive type ([#10883](typescript-eslint/typescript-eslint#10883))
-   **eslint-plugin:** \[prefer-nullish-coalescing] treat `any`/`unknown` as eligible for nullish coalescing ([#10865](typescript-eslint/typescript-eslint#10865))

##### ❤️ Thank You

-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: support DeprecatedInfo in rule.meta.deprecated
2 participants