Skip to content

fix(eslint-plugin): support arbitrary extensions in definition files #10957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2025
Merged

fix(eslint-plugin): support arbitrary extensions in definition files #10957

merged 3 commits into from
Mar 31, 2025

Conversation

dbarabashh
Copy link
Contributor

PR Checklist

Overview

This PR #10911 adds support for TypeScript's allowArbitraryExtensions feature in the isDefinitionFile utility.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dbarabashh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 15, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fce0375
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67d84fd48274a00008d1aaeb
😎 Deploy Preview https://deploy-preview-10957--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 91 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fce0375.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 7m 45s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 12s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6m 48s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 18s View ↗
nx test rule-tester ✅ Succeeded <1s View ↗
nx run integration-tests:test ✅ Succeeded 2m 24s View ↗
nx test ast-spec ✅ Succeeded <1s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-17 16:54:47 UTC

@codecov Codecov
Copy link

codecov bot commented Mar 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (543d36c) to head (fce0375).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10957      +/-   ##
==========================================
+ Coverage   87.58%   87.97%   +0.38%     
==========================================
  Files         470      470              
  Lines       16095    16709     +614     
  Branches     4668     4710      +42     
==========================================
+ Hits        14097    14699     +602     
- Misses       1642     1664      +22     
+ Partials      356      346      -10
Flag Coverage Δ
unittest 87.97% <100.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/util/misc.ts 98.82% <100.00%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks for hopping on this issue! Left a couple of comments. 🚀

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 17, 2025
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9a9670d into typescript-eslint:main Mar 31, 2025
57 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 1, 2025
@renovate
Update typescript-eslint monorepo to v8.29.0
341480a 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 |
| npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |


## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))
-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))
-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))
-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))
-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))

##### ❤️ Thank You

-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)
-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)
-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Ronen Amiel
-   Yannick Decat [@mho22](https://github.com/mho22)
-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.


## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))

##### ❤️ Thank You

-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Yannick Decat [@mho22](https://github.com/mho22)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 1, 2025
@renovate
Update typescript-eslint monorepo to v8.29.0
74b4b8f 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 |
| npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |


## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))
-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))
-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))
-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))
-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))

##### ❤️ Thank You

-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)
-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)
-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Ronen Amiel
-   Yannick Decat [@mho22](https://github.com/mho22)
-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.


## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)

##### 🚀 Features

-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))

##### ❤️ Thank You

-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Yannick Decat [@mho22](https://github.com/mho22)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
aryaemami59 pushed a commit to aryaemami59/typescript-eslint that referenced this pull request Apr 5, 2025
@dbarabashh @aryaemami59
fix(eslint-plugin): support arbitrary extensions in definition files (t…
da696e5 
…ypescript-eslint#10957)

* support arbitrary extensions in definition files

* updated test case

* updated test and refactoring
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: isDefinitionFile utility doesn't consider arbitrary extensions
2 participants
@dbarabashh @JoshuaKGoldberg