Skip to content

fix(eslint-plugin): [no-deprecated] report on deprecated imported variable used as property #10998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ronami
Copy link
Member

@ronami ronami commented Mar 26, 2025

PR Checklist

Overview

This PR addresses #10828 and adjusts the rule to also check the alias chain for a possible deprecation.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cecaeda
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67eaf86eb6f3680008327631
😎 Deploy Preview https://deploy-preview-10998--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Mar 26, 2025

View your CI Pipeline Execution ↗ for commit cecaeda.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 8m 12s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 12s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6m 27s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 18s View ↗
nx test typescript-eslint ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 17s View ↗
nx test eslint-plugin-internal ✅ Succeeded <1s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-31 20:34:58 UTC

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (3dd1835) to head (19f2193).

Current head 19f2193 differs from pull request most recent head cecaeda

Please upload reports for the commit cecaeda to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10998      +/-   ##
==========================================
- Coverage   88.03%   88.02%   -0.01%     
==========================================
  Files         470      470              
  Lines       16801    16790      -11     
  Branches     4745     4742       -3     
==========================================
- Hits        14790    14780      -10     
  Misses       1664     1664              
+ Partials      347      346       -1     
Flag Coverage Δ
unittest 88.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts 94.59% <100.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronami ronami marked this pull request as ready for review March 26, 2025 22:42
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 31, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 04abebc into typescript-eslint:main Apr 7, 2025
55 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 9, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.29.0 | 8.29.1 |
| npm        | @typescript-eslint/parser        | 8.29.0 | 8.29.1 |


## [v8.29.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8291-2025-04-07)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-deprecated] report on deprecated imported variable used as property ([#10998](typescript-eslint/typescript-eslint#10998))

##### ❤️ Thank You

-   Ronen Amiel

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 12, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.29.0 | 8.29.1 |
| npm        | @typescript-eslint/parser        | 8.29.0 | 8.29.1 |


## [v8.29.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8291-2025-04-07)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-deprecated] report on deprecated imported variable used as property ([#10998](typescript-eslint/typescript-eslint#10998))

##### ❤️ Thank You

-   Ronen Amiel

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 13, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.29.0 | 8.29.1 |
| npm        | @typescript-eslint/parser        | 8.29.0 | 8.29.1 |


## [v8.29.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8291-2025-04-07)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-deprecated] report on deprecated imported variable used as property ([#10998](typescript-eslint/typescript-eslint#10998))

##### ❤️ Thank You

-   Ronen Amiel

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] Deprecated imported variable used in an object not detected/reported
2 participants