Skip to content

chore: fix failing integration-tests on Windows #10999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 11, 2025
Merged

chore: fix failing integration-tests on Windows #10999

merged 10 commits into from
Apr 11, 2025

Conversation

aryaemami59
Copy link
Contributor

@aryaemami59 aryaemami59 commented Mar 27, 2025 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 27, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d2ce3b3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67f97e9f5a3ecc0008c4eff5
😎 Deploy Preview https://deploy-preview-10999--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 91 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit d2ce3b3.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 1s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-11 21:01:58 UTC

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Mar 31, 2025
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 31, 2025
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Mar 31, 2025 •
edited
Loading

Note: I merged #11002 and gave it a co-author attribution since it's a subset of this one and also passes.

@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (0f9b55d) to head (d2ce3b3).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10999   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files         486      486           
  Lines       15910    15910           
  Branches     4602     4602           
=======================================
  Hits        13950    13950           
  Misses       1615     1615           
  Partials      345      345
Flag Coverage Δ
unittest 87.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 changed the title chore: fix failing integration-tests chore: fix failing integration-tests on Windows Apr 2, 2025
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 2, 2025
@aryaemami59 aryaemami59 force-pushed the chore/fix-integration-tests branch from 6c630a3 to 85eb947 Compare April 7, 2025 18:46
bradzacher
bradzacher previously approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Legend.

ilikeit.gif

@JoshuaKGoldberg JoshuaKGoldberg merged commit fa265a9 into typescript-eslint:main Apr 11, 2025
59 checks passed
@aryaemami59 aryaemami59 deleted the chore/fix-integration-tests branch April 11, 2025 21:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Integration test failure on main: flat-config-types-@types__eslint-v8 & -v9
3 participants
@aryaemami59 @JoshuaKGoldberg @bradzacher