Skip to content

fix(eslint-plugin): don’t mark declare class as unused #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2019
Merged

fix(eslint-plugin): don’t mark declare class as unused #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3fa7df
fix(eslint-plugin): don’t mark `declare class` as unused
j-f1 Jan 21, 2019
3ec4cb4
Merge branch 'master' into declare-class-is-used
j-f1 Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/eslint-plugin/lib/rules/no-unused-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ module.exports = Object.assign({}, baseRule, {
},
'*[declare=true] Identifier'(node) {
context.markVariableAsUsed(node.name);
const scope = context.getScope();
const { variableScope } = scope;
if (variableScope !== scope) {
const superVar = variableScope.set.get(node.name);
if (superVar) superVar.eslintUsed = true;
}
}
});
}
Expand Down
7 changes: 7 additions & 0 deletions packages/eslint-plugin/tests/lib/rules/no-unused-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,13 @@ declare namespace Foo {
declare var Foo: {
new (value?: any): Object,
foo(): string
}
`,
// https://github.com/typescript-eslint/typescript-eslint/issues/106
`
declare class Foo {
constructor(value?: any): Object;
foo(): string;
}
`,
`
Expand Down