fix(eslint-plugin): [no-deprecated] support for computed literal member access #11006

undsoft · 2025-03-28T20:19:14Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-deprecated] does not report on computed member expressions with a known string literal property #10958
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Adds support for literal member access like a['b']

typescript-eslint · 2025-03-28T20:19:17Z

Thanks for the PR, @undsoft!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-03-28T20:19:30Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`7223496`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/68050fe2e838f60008cb1d87
😎 Deploy Preview	https://deploy-preview-11006--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2025-03-28T20:20:06Z

View your CI Pipeline Execution ↗ for commit 7223496.

Command	Status	Duration	Result
`nx typecheck ast-spec`	✅ Succeeded	<1s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	2s	View ↗
`nx run-many --target=clean`	✅ Succeeded	11s	View ↗

☁️ Nx Cloud last updated this comment at 2025-04-28 05:42:16 UTC

codecov · 2025-03-28T20:35:03Z

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (f30a20e) to head (7223496).

Files with missing lines	Patch %	Lines
packages/eslint-plugin/src/rules/no-deprecated.ts	98.41%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11006   +/-   ##
=======================================
  Coverage   90.82%   90.83%           
=======================================
  Files         497      497           
  Lines       50204    50253   +49     
  Branches     8274     8289   +15     
=======================================
+ Hits        45600    45648   +48     
- Misses       4589     4590    +1     
  Partials       15       15

Flag	Coverage Δ
unittest	`90.83% <98.41%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts	`96.81% <98.41%> (+0.18%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

🙌 Great start, thanks for kicking it off! I think there's just one case around [key] that I think is still missing?

packages/eslint-plugin/src/rules/no-deprecated.ts

…access (typescript-eslint#10958)

…oft/typescript-eslint into 10958-string-literals-in-deprecated

undsoft · 2025-04-04T14:18:15Z

@JoshuaKGoldberg
Okay, I've added support for simple identifiers and template strings.

const myObject = {
  /** @deprecated */
  recommended: null,
};
const key = 'recommended';
const k2 = 'recom';
const k3 = 'mended';

myObject[key]; // Works
myObject[`${k2}${k3}`]; // Works

However, more complex identifiers like:

const myObject = {
  /** @deprecated */
  recommended: null,
};
const key = {
  nested: 'recommended'
} as const;

myObject[key.nested]; // Doesn't work

are not supported, because getPropertyName that I use doesn't seem to understand this construction.

I feel like fixing this may be outside of the scope for this PR? Or otherwise I could use some guidance as to how to do this.

…access (typescript-eslint#10958)

JoshuaKGoldberg

Really lovely progress! 💪

JoshuaKGoldberg · 2025-04-07T12:31:21Z

packages/eslint-plugin/src/rules/no-deprecated.ts

+      if (node.type === AST_NODE_TYPES.MemberExpression && node.computed) {
+        return getComputedPropertyDeprecation(node);
+      }


[Refactor] getComputedPropertyDeprecation is already being called in getDeprecationReason, just after the getCallLikeDeprecation. If we swap the order to try the computed property check first then we'll be able to remove this call here:

Suggested change

if (node.type === AST_NODE_TYPES.MemberExpression && node.computed) {

return getComputedPropertyDeprecation(node);

}

function getDeprecationReason(node: IdentifierLike): string | undefined { if (isInComputedProperty(node)) { return getComputedPropertyDeprecation( node.parent as TSESTree.MemberExpression, ); } const callLikeNode = getCallLikeNode(node); if (callLikeNode) { return getCallLikeDeprecation(callLikeNode); }

JoshuaKGoldberg · 2025-04-07T12:34:26Z

packages/eslint-plugin/tests/rules/no-deprecated.test.ts

+      errors: [
+        {
+          column: 11,
+          data: { name: 'key' },


[Bug] key isn't deprecated, b is. TypeScript correctly reports 'b' is deprecated. so the rule should too.

https://deploy-preview-11006--typescript-eslint.netlify.app/play/#ts=5.8.2&fileType=.ts&code=MYewdgzgLgBAhjAvDA3gKBjA9AKhzAAQBMBTABwCcTg4oSiYcsMYAjALhgEYAaNAXwDcaNKEiwA1iQCeSGAHJW84WjgBtKdIC6goA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oBNFjpEZAIb5E3dFETRoHaJHBgAviEVA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

(here and elsewhere)

JoshuaKGoldberg · 2025-04-07T12:37:21Z

packages/eslint-plugin/src/rules/no-deprecated.ts

@@ -232,7 +266,7 @@ export default createRule<Options, MessageIds>({
      }
    }

-    function getCallLikeNode(node: TSESTree.Node): CallLikeNode | undefined {
+    function getCallLikeNode(node: TSESTree.Node): CalleeNode | undefined {


[Naming] If the type's name is switched from CalleeNode to CallLikeNode, the corresponding get* function's name should too:

Suggested change

function getCallLikeNode(node: TSESTree.Node): CalleeNode | undefined {

function getCalleNode(node: TSESTree.Node): CalleeNode | undefined {

JoshuaKGoldberg · 2025-04-07T12:39:44Z

fixing this may be outside of the scope for this PR?

Agreed, yeah - I think it'd be good as a followup issue.

…access (typescript-eslint#10958)

…958-string-literals-in-deprecated

…access (typescript-eslint#10958)

undsoft · 2025-04-20T15:35:30Z

Okay, I believe I've addressed the comments.

fix(eslint-plugin): [no-deprecated] adds support for string literal m…

845839a

…ember access (typescript-eslint#10958)

Merge branch 'main' into 10958-string-literals-in-deprecated

0d81a5b

JoshuaKGoldberg requested changes Mar 31, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-deprecated.ts Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 31, 2025

undsoft added 3 commits April 4, 2025 16:00

fix(eslint-plugin): [no-deprecated] adds support for computed member …

82f748f

…access (typescript-eslint#10958)

Merge branch 'main' into 10958-string-literals-in-deprecated

21ffe65

Merge branch '10958-string-literals-in-deprecated' of github.com:unds…

4c24c44

…oft/typescript-eslint into 10958-string-literals-in-deprecated

undsoft requested a review from JoshuaKGoldberg April 4, 2025 14:18

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 4, 2025

fix(eslint-plugin): [no-deprecated] adds support for computed member …

74c79d9

…access (typescript-eslint#10958)

JoshuaKGoldberg requested changes Apr 7, 2025

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Apr 7, 2025

undsoft added 3 commits April 20, 2025 16:55

fix(eslint-plugin): [no-deprecated] adds support for computed member …

cb50efe

…access (typescript-eslint#10958)

Merge branch 'master' of github.com:undsoft/typescript-eslint into 10…

b749c56

…958-string-literals-in-deprecated

fix(eslint-plugin): [no-deprecated] adds support for computed member …

7223496

…access (typescript-eslint#10958)

undsoft requested a review from JoshuaKGoldberg April 20, 2025 15:35

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 20, 2025

kirkwaiblinger changed the title ~~fix(eslint-plugin): [no-deprecated] support for literal member access (#10958)~~ fix(eslint-plugin): [no-deprecated] support for computed literal member access Apr 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [no-deprecated] support for computed literal member access #11006

fix(eslint-plugin): [no-deprecated] support for computed literal member access #11006

undsoft commented Mar 28, 2025

typescript-eslint bot commented Mar 28, 2025

netlify bot commented Mar 28, 2025 •

edited

Loading

nx-cloud bot commented Mar 28, 2025 •

edited

Loading

codecov bot commented Mar 28, 2025 •

edited

Loading

JoshuaKGoldberg left a comment

undsoft commented Apr 4, 2025 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg Apr 7, 2025

JoshuaKGoldberg Apr 7, 2025

JoshuaKGoldberg Apr 7, 2025

JoshuaKGoldberg commented Apr 7, 2025

undsoft commented Apr 20, 2025

	if (node.type === AST_NODE_TYPES.MemberExpression && node.computed) {
	return getComputedPropertyDeprecation(node);
	}

	function getCallLikeNode(node: TSESTree.Node): CalleeNode \| undefined {
	function getCalleNode(node: TSESTree.Node): CalleeNode \| undefined {

fix(eslint-plugin): [no-deprecated] support for computed literal member access #11006

Are you sure you want to change the base?

fix(eslint-plugin): [no-deprecated] support for computed literal member access #11006

Conversation

undsoft commented Mar 28, 2025

PR Checklist

Overview

typescript-eslint bot commented Mar 28, 2025

netlify bot commented Mar 28, 2025 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Mar 28, 2025 • edited Loading

codecov bot commented Mar 28, 2025 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

undsoft commented Apr 4, 2025 • edited Loading

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg Apr 7, 2025

Choose a reason for hiding this comment

JoshuaKGoldberg Apr 7, 2025

Choose a reason for hiding this comment

JoshuaKGoldberg Apr 7, 2025

Choose a reason for hiding this comment

JoshuaKGoldberg commented Apr 7, 2025

undsoft commented Apr 20, 2025

netlify bot commented Mar 28, 2025 •

edited

Loading

nx-cloud bot commented Mar 28, 2025 •

edited

Loading

codecov bot commented Mar 28, 2025 •

edited

Loading

undsoft commented Apr 4, 2025 •

edited

Loading