Skip to content

docs: fix typos in no-unsafe-argument examples #11007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

docs: fix typos in no-unsafe-argument examples #11007

merged 2 commits into from
Mar 31, 2025

Conversation

takuyahara
Copy link
Contributor

Some lines in example code are incorrect.

PR Checklist

Overview

@takuyahara
Update no-unsafe-argument.mdx
5ce926e 
Some lines in example code are incorrect.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @takuyahara!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 28, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3d16721
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67ea9340c3e0e10008c00789
😎 Deploy Preview https://deploy-preview-11007--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3d16721.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 7m 47s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6m 33s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 21s View ↗
nx test utils ✅ Succeeded 1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test typescript-eslint ✅ Succeeded 4s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 22s View ↗
nx test visitor-keys ✅ Succeeded <1s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-31 13:23:13 UTC

@Josh-Cena Josh-Cena changed the title Update no-unsafe-argument.mdx docs: fix typo Mar 28, 2025
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the spot! 👁️

@JoshuaKGoldberg JoshuaKGoldberg changed the title docs: fix typo docs: fix typos in no-unsafe-argument examples Mar 31, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (5b187f4) to head (3d16721).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11007   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         470      470           
  Lines       16793    16793           
  Branches     4744     4744           
=======================================
  Hits        14786    14786           
  Misses       1662     1662           
  Partials      345      345
Flag Coverage Δ
unittest 88.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg merged commit c7c9b1a into typescript-eslint:main Mar 31, 2025
56 of 57 checks passed
@takuyahara takuyahara deleted the patch-1 branch April 1, 2025 11:22
aryaemami59 pushed a commit to aryaemami59/typescript-eslint that referenced this pull request Apr 5, 2025
@takuyahara @JoshuaKGoldberg @aryaemami59
docs: fix typos in no-unsafe-argument examples (typescript-eslint#11007)
b956b1a 
* Update no-unsafe-argument.mdx

Some lines in example code are incorrect.

* update test snapshot

---------

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takuyahara @JoshuaKGoldberg