Skip to content

fix(eslint-plugin): [prefer-nullish-coalescing] handle generic type #11019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(eslint-plugin): [prefer-nullish-coalescing] handle generic type #11019

wants to merge 1 commit into from

Conversation

OlivierZal
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 31, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a5b7c3a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67eb25d3228a460008a58cc7
😎 Deploy Preview https://deploy-preview-11019--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlivierZal
Copy link
Contributor Author

Cc @kirkwaiblinger

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a5b7c3a.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 7m 45s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6m 31s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 23s View ↗
nx test typescript-estree ✅ Succeeded 1m 17s View ↗
nx test type-utils ✅ Succeeded 29s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test scope-manager ✅ Succeeded 15s View ↗
nx test typescript-eslint ✅ Succeeded 4s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-31 23:47:07 UTC

@OlivierZal OlivierZal force-pushed the prefer-nullish-coalescing-7842 branch 2 times, most recently from 5a3ee2c to 59b0803 Compare March 31, 2025 20:47
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (3dd1835) to head (a5b7c3a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11019   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         470      470           
  Lines       16801    16807    +6     
  Branches     4745     4747    +2     
=======================================
+ Hits        14790    14796    +6     
  Misses       1664     1664           
  Partials      347      347
Flag Coverage Δ
unittest 88.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 96.76% <100.00%> (+0.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OlivierZal OlivierZal force-pushed the prefer-nullish-coalescing-7842 branch from e047b5d to da71ec1 Compare March 31, 2025 21:13
@OlivierZal OlivierZal marked this pull request as draft March 31, 2025 21:22
@OlivierZal OlivierZal force-pushed the prefer-nullish-coalescing-7842 branch 4 times, most recently from 850910e to b1b253f Compare March 31, 2025 23:12
@OlivierZal OlivierZal marked this pull request as ready for review March 31, 2025 23:23
@OlivierZal OlivierZal force-pushed the prefer-nullish-coalescing-7842 branch from 74698c9 to 9ea7b45 Compare March 31, 2025 23:30
@OlivierZal OlivierZal force-pushed the prefer-nullish-coalescing-7842 branch from 9ea7b45 to a5b7c3a Compare March 31, 2025 23:31
@OlivierZal OlivierZal marked this pull request as draft April 1, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@OlivierZal