chore: remove unused downlevel-dts #11034
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View your CI Pipeline Execution ↗ for commit c4e843d.
☁️ Nx Cloud last updated this comment at |
|
Heh, I should have sent this as a draft first and re-read it. thanks :) will take the suggestions |
Co-authored-by: Arya Emami <aryaemami59@yahoo.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11034 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 497 497
Lines 17840 17840
Branches 4803 4803
=======================================
Hits 15730 15730
Misses 1775 1775
Partials 335 335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| "clean": "tsc -b tsconfig.build.json --clean", | ||
| "postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage", | ||
| "postclean": "rimraf dist/ coverage/", |
There was a problem hiding this comment.
Question: is there a reason the suggestion added /s at the end? I can never keep track which tools prefer to exclude or include them 😄
There was a problem hiding this comment.
It's just to be explicit about the fact that they're directories.
f6d7e95
f1ceade
into
typescript-eslint:main
PR Checklist
Overview
🔪