fix(typescript-eslint): address bugs in config() around global ignores
#11065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y meta keys - `config-helper.ts` only adds base config to config array if it contains keys other than `files`, `ignores`, `names`. - Fixes bug where config helper would create global ignores when extending with base config of `ignores` - Fixes bug where config helper creates extraneous config when extending with base config of only `files`, `ignores`, `names`
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View your CI Pipeline Execution ↗ for commit c3cd861.
☁️ Nx Cloud last updated this comment at |
…lobal-ignore-in-config
814670c to
0731285
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11065 +/- ##
=======================================
Coverage 84.31% 84.32%
=======================================
Files 497 497
Lines 27766 27778 +12
Branches 5075 5082 +7
=======================================
+ Hits 23411 23423 +12
Misses 4184 4184
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Merged
3 tasks
bradzacher
approved these changes
Apr 15, 2025
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
config-helper.tshas unexpected behavior when base config contains only meta keys #10754Overview
Continuation of #10755.
Co-authored-by: @jeremy-code