Skip to content

chore: corrected vitest.config.base compiler inclusion #11067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

chore: corrected vitest.config.base compiler inclusion #11067

merged 1 commit into from
Apr 14, 2025

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 14, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ad1d773
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fcfec436ce4c0008e06518
😎 Deploy Preview https://deploy-preview-11067--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 14, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ad1d773.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 7m 44s View ↗
nx test type-utils ✅ Succeeded 27s View ↗
nx test visitor-keys ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 39s View ↗
nx test typescript-estree ✅ Succeeded 1m 16s View ↗
nx run-many --target=clean ✅ Succeeded 18s View ↗
nx test typescript-eslint ✅ Succeeded 7s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 12:43:27 UTC

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 14, 2025 12:40
@JoshuaKGoldberg JoshuaKGoldberg merged commit 6e03f7c into typescript-eslint:main Apr 14, 2025
54 checks passed
@codecov Codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (0f9b55d) to head (ad1d773).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11067      +/-   ##
==========================================
+ Coverage   87.68%   87.80%   +0.12%     
==========================================
  Files         486      459      -27     
  Lines       15910    15683     -227     
  Branches     4602     4580      -22     
==========================================
- Hits        13950    13770     -180     
+ Misses       1615     1569      -46     
+ Partials      345      344       -1
Flag Coverage Δ
unittest 87.80% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Build failures on vitest.config.base
1 participant
@JoshuaKGoldberg