Skip to content

chore: update vscode launch tasks to use vitest #11076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

chore: update vscode launch tasks to use vitest #11076

merged 1 commit into from
Apr 22, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Apr 15, 2025

Updates the launch task to use vitest for running tests.

Note that I didn't (yet?) enable single thread mode in vitest as it isn't quite the equivalent to jest's runInBand. From what I understand, vitest will always run tests in another thread even in single thread mode (as in there will be one process running vitest, and one running tests).

I also noticed there was a duplicate path in the existing skip lists, so have updated that.

cc @kirkwaiblinger @aryaemami59

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6f7c4be
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fe7aba372af10008b6a5d6
😎 Deploy Preview https://deploy-preview-11076--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6f7c4be.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-15 16:25:20 UTC

@kirkwaiblinger
Copy link
Member

Tried this out locally - for the most part, it works great! One thing that's kind of clunky though is that debugging a test case can cause it to fail due to test timeouts. Is there a way to fix that?

@43081j
Copy link
Contributor Author

43081j commented Apr 15, 2025

maybe we just need to disable the timeout in the task?

as in --testTimeout=0

@43081j
chore: update vscode launch tasks to use vitest
6f7c4be 
Updates the launch task to use vitest for running tests.
@kirkwaiblinger
Copy link
Member

Nice, yeah the --testTimeout=0 solved that error 👍 There's still some issue with Error: [vitest-worker]: Timeout calling "onTaskUpdate" but it doesn't really block anything 🤷

Also I tried all the options at https://vitest.dev/guide/debugging.html#vs-code and it didn't seem to solve it. Oh well!

kirkwaiblinger
kirkwaiblinger approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thank you!

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 15, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5c2f474 into typescript-eslint:main Apr 22, 2025
55 of 56 checks passed
@43081j 43081j deleted the launch-codes branch April 22, 2025 12:50
phaux pushed a commit to phaux/typescript-eslint that referenced this pull request Apr 24, 2025
@43081j @phaux
chore: update vscode launch tasks to use vitest (typescript-eslint#11076
40fc0c4 
)

Updates the launch task to use vitest for running tests.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Make F5 Launch config work with vitest
3 participants
@43081j @kirkwaiblinger @JoshuaKGoldberg