Skip to content

chore: remove jest leftovers #11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

chore: remove jest leftovers #11078

merged 3 commits into from
Apr 28, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Apr 15, 2025 •
edited by JoshuaKGoldberg
Loading

Removes any leftover jest dependencies and files.

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 22f637a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/680fdc1fe57a0d0008345d6f
😎 Deploy Preview https://deploy-preview-11078--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 22f637a.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-28 20:08:37 UTC

@43081j
chore: remove jest leftovers
6c4a4cd 
Removes any leftover jest dependencies and files.
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the note that there are still some leftovers after this. They're discoverable from searching jest in the repo excluding CHANGELOG.md files:

  • .gitattributes: a few lines
  • The comment on top of nx-migrate.yml
  • .vscode/extensions.json & .vscode/launch.json
  • etc.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 21, 2025
kirkwaiblinger
kirkwaiblinger previously approved these changes Apr 28, 2025
View reviewed changes
@kirkwaiblinger kirkwaiblinger dismissed stale reviews from JoshuaKGoldberg and themself via 22f637a April 28, 2025 19:50
@codecov Codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (f5c588c) to head (22f637a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11078   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         497      497           
  Lines       50259    50259           
  Branches     8291     8291           
=======================================
  Hits        45652    45652           
  Misses       4592     4592           
  Partials       15       15
Flag Coverage Δ
unittest 90.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) April 28, 2025 19:52
@kirkwaiblinger kirkwaiblinger merged commit 1200571 into typescript-eslint:main Apr 28, 2025
56 of 57 checks passed
@kirkwaiblinger kirkwaiblinger mentioned this pull request Apr 29, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@43081j @JoshuaKGoldberg @kirkwaiblinger