Skip to content

chore(type-utils): finish migrating to vitest #11104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore(type-utils): finish migrating to vitest #11104

wants to merge 12 commits into from
+614 −575

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 27, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4fbfcf8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6812882e6a44590008767964
😎 Deploy Preview https://deploy-preview-11104--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 77 (🔴 down 21 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4fbfcf8.

Command Status Duration Result
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 22s View ↗
nx test eslint-plugin ✅ Succeeded 6m 2s View ↗
nx test eslint-plugin-internal ✅ Succeeded 11s View ↗
nx test parser ✅ Succeeded 9s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx typecheck ast-spec ✅ Succeeded 4s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1m 11s View ↗
nx run type-utils:test -- --coverage ✅ Succeeded 24s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-30 20:48:58 UTC

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 27, 2025

View your CI Pipeline Execution ↗ for commit 8462db9.

Command Status Duration Result
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-27 00:44:58 UTC

@aryaemami59 aryaemami59 marked this pull request as ready for review April 27, 2025 01:28
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (d8b76f8) to head (4fbfcf8).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11104   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         497      497           
  Lines       50279    50279           
  Branches     8297     8297           
=======================================
  Hits        45672    45672           
  Misses       4592     4592           
  Partials       15       15
Flag Coverage Δ
unittest 90.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo(type-utils): finish migrating to vitest
1 participant
@aryaemami59