Skip to content

chore: lint vitest config files #11106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 29, 2025
Merged

chore: lint vitest config files #11106

merged 6 commits into from
Apr 29, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 27, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bc12363
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/680ff6692e47330009fc3f30
😎 Deploy Preview https://deploy-preview-11106--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bc12363.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 5m 58s View ↗
nx test ast-spec ✅ Succeeded 14s View ↗
nx test utils ✅ Succeeded 12s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test typescript-eslint ✅ Succeeded 4s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 16s View ↗
nx test type-utils ✅ Succeeded 23s View ↗
nx typecheck ast-spec ✅ Succeeded 5s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-28 22:02:05 UTC

kirkwaiblinger
kirkwaiblinger previously approved these changes Apr 28, 2025
View reviewed changes
@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 28, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (50ef8d9) to head (bc12363).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11106   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         497      497           
  Lines       50279    50279           
  Branches     8297     8297           
=======================================
  Hits        45672    45672           
  Misses       4592     4592           
  Partials       15       15
Flag Coverage Δ
unittest 90.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger merged commit f7ea991 into typescript-eslint:main Apr 29, 2025
58 of 59 checks passed
@aryaemami59 aryaemami59 deleted the chore/lint-vitest-config-files branch April 30, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: lint vitest config files
2 participants
@aryaemami59 @kirkwaiblinger