Skip to content

fix(typescript-eslint): correct TSImportType property name when assert #11115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(typescript-eslint): correct TSImportType property name when assert #11115

wants to merge 1 commit into from

Conversation

overlookmotel
Copy link

PR Checklist

Overview

I guess token.getText() is the best API to use to obtain the property name, but I'm unfamiliar with both typescript-eslint and TypeScript compiler, so I may well be on the wrong track. Ditto I think I've put the test in the right place.

If any changes required (or if I've gone about this in completely the wrong way), please do let me know.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @overlookmotel!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 29, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 33db5e9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6810af1907968a0008118ea7
😎 Deploy Preview https://deploy-preview-11115--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 33db5e9.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-29 11:07:48 UTC

@overlookmotel overlookmotel mentioned this pull request Apr 29, 2025
Open
4 tasks
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (50ef8d9) to head (33db5e9).

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 0.00% 10 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11115      +/-   ##
==========================================
- Coverage   90.83%   90.82%   -0.01%     
==========================================
  Files         497      497              
  Lines       50279    50284       +5     
  Branches     8297     8297              
==========================================
  Hits        45672    45672              
- Misses       4592     4597       +5     
  Partials       15       15
Flag Coverage Δ
unittest 90.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 30.69% <0.00%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@overlookmotel
Copy link
Author

Could someone please advise on how to fix the codecov/patch CI fail? I'm a bit baffled as the changes made to tests does exercise multiple possible values of withOrAssertName. Is it just due to using longer var names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: TSImportType's option object always has key with
1 participant
@overlookmotel