Skip to content

fix(typescript-estree): the token value of an escaped identifier differs with espree #11116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(typescript-estree): the token value of an escaped identifier differs with espree #11116

wants to merge 1 commit into from

Conversation

dbarabashh
Copy link
Contributor

@dbarabashh dbarabashh commented Apr 29, 2025 •
edited
Loading

PR Checklist

Overview

Show case 1 Show case 2

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dbarabashh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 29, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8e99c65
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6810efc214832a0008ecdd2b
😎 Deploy Preview https://deploy-preview-11116--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8e99c65.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 3s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-29 15:45:02 UTC

@dbarabashh dbarabashh changed the title fix(eslint-plugin): decode unicode escapes in identifier tokens fix(eslint-plugin): the token value of an escaped identifier differs with espree Apr 29, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (50ef8d9) to head (8e99c65).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11116   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         497      497           
  Lines       50279    50291   +12     
  Branches     8297     8301    +4     
=======================================
+ Hits        45672    45684   +12     
  Misses       4592     4592           
  Partials       15       15
Flag Coverage Δ
unittest 90.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/node-utils.ts 63.81% <100.00%> (+0.68%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dbarabashh dbarabashh changed the title fix(eslint-plugin): the token value of an escaped identifier differs with espree fix(typescript-estree): the token value of an escaped identifier differs with espree Apr 29, 2025
@dbarabashh
Copy link
Contributor Author

I’m not sure the current CI/CD error is actually caused by my changes but I cant say for certain. I think I need some help.
@JoshuaKGoldberg @bradzacher

@rubiesonthesky
Copy link
Contributor

It looks like this same error is happening on main branch f7ea991 - so probably it has nothing to do with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The token value of an escaped identifier differs with espree
2 participants
@dbarabashh @rubiesonthesky