Skip to content

chore: revert vitest related changes in tsconfig files #11124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

chore: revert vitest related changes in tsconfig files #11124

merged 2 commits into from
May 2, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@aryaemami59 aryaemami59 force-pushed the chore/revert-vitest-config-tsconfig-changes branch from 7065634 to f5d084f Compare May 1, 2025 14:01
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fb5b667.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 6m 23s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 15s View ↗
nx test typescript-eslint ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx typecheck ast-spec ✅ Succeeded 1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 41s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 8s View ↗
nx run-many --target=clean ✅ Succeeded 19s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-05-01 14:38:01 UTC

@netlify Netlify
Copy link

netlify bot commented May 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7065634
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/68137eb7b5891b000857b9a2
😎 Deploy Preview https://deploy-preview-11124--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fb5b667
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6813824bcac54e0008bda11c
😎 Deploy Preview https://deploy-preview-11124--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okily dokily

@JoshuaKGoldberg JoshuaKGoldberg merged commit a9c9251 into typescript-eslint:main May 2, 2025
58 checks passed
@aryaemami59 aryaemami59 deleted the chore/revert-vitest-config-tsconfig-changes branch May 3, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @kirkwaiblinger