Skip to content

chore(ast-spec): finish migrating to vitest #11126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore(ast-spec): finish migrating to vitest #11126

wants to merge 5 commits into from
+247 −103

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 3, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8e5bf31
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6818fea3feeef40008812152
😎 Deploy Preview https://deploy-preview-11126--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 91 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8e5bf31.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 49s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-05 18:51:53 UTC

@aryaemami59 aryaemami59 marked this pull request as ready for review May 3, 2025 21:39
@aryaemami59 aryaemami59 force-pushed the chore/ast-spec-vitest-migration branch from 2d1c979 to 94a5c9a Compare May 5, 2025 12:20
@codecov Codecov
Copy link

codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (ccbfcdc) to head (94a5c9a).
Report is 42 commits behind head on main.

❗ Current head 94a5c9a differs from pull request most recent head 8e5bf31

Please upload reports for the commit 8e5bf31 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11126      +/-   ##
==========================================
- Coverage   90.90%   90.84%   -0.07%     
==========================================
  Files         498      497       -1     
  Lines       50655    50320     -335     
  Branches     8335     8311      -24     
==========================================
- Hits        46049    45714     -335     
  Misses       4591     4591              
  Partials       15       15
Flag Coverage Δ
unittest 90.84% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo(ast-spec): finish migrating to vitest
2 participants
@aryaemami59 @JoshuaKGoldberg