-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(website): acquired types are shown in the editor but not reflected in linting #11198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(website): acquired types are shown in the editor but not reflected in linting #11198
Conversation
Thanks for the PR, @mdm317! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
View your CI Pipeline Execution ↗ for commit f5d9dfb.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11198 +/- ##
=======================================
Coverage 90.91% 90.92%
=======================================
Files 499 499
Lines 50809 50845 +36
Branches 8369 8384 +15
=======================================
+ Hits 46195 46231 +36
Misses 4599 4599
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
PR Checklist
Overview
I think this issue occurs because of differences in the properties used when creating a ts.Program between Monaco and TypeScript-VFS.
The modules like monaco, [typescript]
(https://github.com/microsoft/TypeScript), and typescript-website are scattered, so it’s a bit confusing
1. create
ts.program
by monaceWhen monaco-editor creating this code will excute link
private _languageService = ts.createLanguageService(this);
createLanguageService in typescript. link
And filenames output by
getScriptFileNames
will be added in the code below.defaults.addExtraLib(code, path)
in typescript-website =>defaults.addExtraLib(code, path)
in monacoSo, when creating a ts.Program, the rootNames array includes some libraries, such as Node or React.
2. create
ts.program
by TypeScript-VFS.Unlike case 1 above,We don't pass the name of a node_modules folder in fileNames.
In the sentence above, I modified it so that rootNames are provided when creating the
ts.Program
for both the Editor and Linting