Skip to content

docs: add note about max-semi-size to performance section #11200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: add note about max-semi-size to performance section #11200

wants to merge 2 commits into from
+8 −0

Conversation

maschwenk
Copy link

PR Checklist

Overview

This setting has improved the performance of typed linting of our biggest app (~2.5 million LoC) by a factor of 2x.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @maschwenk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 10, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 903cf3f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6821ec5c197bfb0008b0d014
😎 Deploy Preview https://deploy-preview-11200--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 903cf3f.

Command Status Duration Result
nx run-many --target=clean ✅ Succeeded 12s View ↗
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-12 12:55:51 UTC

@maschwenk maschwenk changed the title Add note about max-semi-size to performance section docs: Add note about max-semi-size to performance section May 11, 2025
@maschwenk maschwenk changed the title docs: Add note about max-semi-size to performance section docs: add note about max-semi-size to performance section May 11, 2025
@maschwenk
Copy link
Author

My reproduction case here really requires you have a disgustingly large app to repro, so unsure if there are ideas

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I'd like to defer to @bradzacher as the tsc-at-scale 👑

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 12, 2025
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 12, 2025
@maschwenk @JoshuaKGoldberg
Update docs/troubleshooting/typed-linting/Performance.mdx
903cf3f 
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 12, 2025
@codecov Codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (e57126a) to head (903cf3f).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11200   +/-   ##
=======================================
  Coverage   90.91%   90.92%           
=======================================
  Files         499      499           
  Lines       50809    50845   +36     
  Branches     8369     8384   +15     
=======================================
+ Hits        46195    46231   +36     
  Misses       4599     4599           
  Partials       15       15
Flag Coverage Δ
unittest 90.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@bradzacher bradzacher Awaiting requested review from bradzacher

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maschwenk @JoshuaKGoldberg