Skip to content

chore: migrate eslint-plugin-import to eslint-plugin-import-x #11217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: migrate eslint-plugin-import to eslint-plugin-import-x #11217

wants to merge 2 commits into from
+1,632 −982

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented May 14, 2025

PR Checklist

Overview

Before:

 typescript-eslint on  main ❯ TIMING=1 y eslint .
Rule                                               | Time (ms) | Relative
:--------------------------------------------------|----------:|--------:
@typescript-eslint/no-unsafe-assignment            |  5458.780 |    22.9%
@typescript-eslint/internal/plugin-test-formatting |  3047.222 |    12.8%
@typescript-eslint/no-floating-promises            |  2288.399 |     9.6%
@typescript-eslint/no-misused-promises             |  2215.349 |     9.3%
@typescript-eslint/no-unsafe-return                |  1609.052 |     6.8%
@typescript-eslint/no-deprecated                   |  1049.075 |     4.4%
@typescript-eslint/no-unsafe-argument              |   954.879 |     4.0%
@typescript-eslint/no-unsafe-member-access         |   528.152 |     2.2%
import/no-duplicates                               |   501.363 |     2.1%
perfectionist/sort-objects                         |   373.923 |     1.6%
via .NET via  v24.0.1 took 1m13s

 typescript-eslint on  chore/import-x [+] ❯ TIMING=1 y eslint .
Rule                                               | Time (ms) | Relative
:--------------------------------------------------|----------:|--------:
@typescript-eslint/no-unsafe-assignment            |  3212.736 |    15.9%
@typescript-eslint/internal/plugin-test-formatting |  3052.515 |    15.1%
@typescript-eslint/no-floating-promises            |  2319.146 |    11.5%
@typescript-eslint/no-misused-promises             |  2253.580 |    11.2%
@typescript-eslint/no-unsafe-return                |  1785.357 |     8.9%
@typescript-eslint/no-unsafe-argument              |   932.104 |     4.6%
@typescript-eslint/no-deprecated                   |   906.925 |     4.5%
@typescript-eslint/no-unsafe-member-access         |   528.508 |     2.6%
@typescript-eslint/no-unnecessary-condition        |   321.524 |     1.6%
perfectionist/sort-objects                         |   298.678 |     1.5%
via .NET via  v24.0.1 took 1m8s

For a single ESLint plugin migration, I believe from 1m13s to 1m8s is already good enough, and it founds a false positive that @docusaurus/plugin-content-blog should be listed in dependencies for website, because eslint-plugin-import-x is a TypeScript rewrite started at un-ts/eslint-plugin-import-x#42 and we fixed several hidden bugs thanks to TypeScript!

(I don't know why nx complains about react-helmet-async version incompatible with @docusaurus/core's, see also https://app.unpkg.com/@docusaurus/core@3.7.0/files/package.json#L63, so I'm locking it same way to make nx happy.)

cc @JoshuaKGoldberg

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JounQin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 14, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e1bf907
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6824aaab7d8d2100086fa1ad
😎 Deploy Preview https://deploy-preview-11217--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (🟢 up 2 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JounQin JounQin mentioned this pull request May 14, 2025
Open
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 14, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e1bf907.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 6m 19s View ↗
nx test utils ✅ Succeeded 13s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 23s View ↗
nx typecheck ast-spec ✅ Succeeded 1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 3s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 4m 58s View ↗
nx run-many --target=clean ✅ Succeeded 20s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-05-14 14:52:53 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: migrate eslint-plugin-import to eslint-plugin-import-x
1 participant
@JounQin