Skip to content

chore: fix issues introduced by updated nx configuration #11230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore: fix issues introduced by updated nx configuration #11230

wants to merge 6 commits into from
+363 −282

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 21, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1b44a74
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/683e136caad7b400087c2d11
😎 Deploy Preview https://deploy-preview-11230--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1b44a74.

Command Status Duration Result
nx run utils:test -- --coverage ❌ Failed 5s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 11s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 12s View ↗
nx run-many -t lint ✅ Succeeded 1m 59s View ↗
nx run integration-tests:test ✅ Succeeded 53s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 20s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 8s View ↗
nx run generate-configs ✅ Succeeded 12s View ↗
Additional runs (17) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-02 21:19:41 UTC

@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (936f350) to head (89e7198).

❗ Current head 89e7198 differs from pull request most recent head 1b44a74

Please upload reports for the commit 1b44a74 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11230   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files         501      501           
  Lines       50869    50869           
  Branches     8382     8382           
=======================================
  Hits        46248    46248           
  Misses       4606     4606           
  Partials       15       15
Flag Coverage Δ
unittest 90.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: address issues introduced by updated nx configuration
1 participant
@aryaemami59