typescript-eslint · fisker · May 21, 2025 · May 21, 2025 · May 21, 2025 · May 21, 2025
diff --git a/.../src/declaration/TSEnumDeclaration/fixtures/with-member-one/snapshots/1-TSESTree-AST.shot b/.../src/declaration/TSEnumDeclaration/fixtures/with-member-one/snapshots/1-TSESTree-AST.shot
diff --git a/...declaration/TSEnumDeclaration/fixtures/with-member-one/snapshots/5-AST-Alignment-AST.shot b/...declaration/TSEnumDeclaration/fixtures/with-member-one/snapshots/5-AST-Alignment-AST.shot
diff --git a/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/bigint-name/fixture.ts b/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/bigint-name/fixture.ts
@@ -0,0 +1,3 @@
+enum Foo {
+  1n = 2
+}
diff --git a/...pec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/1-TSESTree-Error.shot b/...pec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/1-TSESTree-Error.shot
diff --git a/...t-spec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/2-Babel-Error.shot b/...t-spec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/2-Babel-Error.shot
diff --git a/...ec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/3-Alignment-Error.shot b/...ec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/number-name/fixture.ts b/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/number-name/fixture.ts
@@ -0,0 +1,3 @@
+enum Foo {
+  1 = 2
+}
diff --git a/...pec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/1-TSESTree-Error.shot b/...pec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/1-TSESTree-Error.shot
diff --git a/...t-spec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/2-Babel-Error.shot b/...t-spec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/2-Babel-Error.shot
diff --git a/...ec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/3-Alignment-Error.shot b/...ec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/element/TSEnumMember/spec.ts b/packages/ast-spec/src/element/TSEnumMember/spec.ts
@@ -1,44 +1,15 @@
 import type { AST_NODE_TYPES } from '../../ast-node-types';
 import type { BaseNode } from '../../base/BaseNode';
+import type { Identifier } from '../../expression/Identifier/spec';
+import type { StringLiteral } from '../../expression/literal/StringLiteral/spec';
 import type { Expression } from '../../unions/Expression';
-import type {
-  PropertyNameComputed,
-  PropertyNameNonComputed,
-} from '../../unions/PropertyName';
 
-interface TSEnumMemberBase extends BaseNode {
+export interface TSEnumMember extends BaseNode {
   type: AST_NODE_TYPES.TSEnumMember;
-  computed: boolean;
-  id:
-    | PropertyNameComputed // this should only happen in semantically invalid code (ts error 1164)
-    | PropertyNameNonComputed;
+  id: Identifier | StringLiteral;
   initializer: Expression | undefined;
+  /**
+   * @deprecated the enum member is always non-computed.
+   */
+  computed: boolean;
 }
-
-/**
- * this should only really happen in semantically invalid code (errors 1164 and 2452)
- *
- * @example
- * ```ts
- * // VALID:
- * enum Foo { ['a'] }
- *
- * // INVALID:
- * const x = 'a';
- * enum Foo { [x] }
- * enum Bar { ['a' + 'b'] }
- * ```
- */
-export interface TSEnumMemberComputedName extends TSEnumMemberBase {
-  computed: true;
-  id: PropertyNameComputed;
-}
-
-export interface TSEnumMemberNonComputedName extends TSEnumMemberBase {
-  computed: false;
-  id: PropertyNameNonComputed;
-}
-
-export type TSEnumMember =
-  | TSEnumMemberComputedName
-  | TSEnumMemberNonComputedName;
diff --git a/...basics/fixtures/_error_/export-named-enum-computed-number/snapshots/1-TSESTree-Error.shot b/...basics/fixtures/_error_/export-named-enum-computed-number/snapshots/1-TSESTree-Error.shot
diff --git a/...asics/fixtures/_error_/export-named-enum-computed-number/snapshots/3-Alignment-Error.shot b/...asics/fixtures/_error_/export-named-enum-computed-number/snapshots/3-Alignment-Error.shot
diff --git a/...basics/fixtures/_error_/export-named-enum-computed-string/snapshots/1-TSESTree-Error.shot b/...basics/fixtures/_error_/export-named-enum-computed-string/snapshots/1-TSESTree-Error.shot
diff --git a/...asics/fixtures/_error_/export-named-enum-computed-string/snapshots/3-Alignment-Error.shot b/...asics/fixtures/_error_/export-named-enum-computed-string/snapshots/3-Alignment-Error.shot
diff --git a/...asics/fixtures/_error_/export-named-enum-computed-var-ref/snapshots/1-TSESTree-Error.shot b/...asics/fixtures/_error_/export-named-enum-computed-var-ref/snapshots/1-TSESTree-Error.shot
diff --git a/...sics/fixtures/_error_/export-named-enum-computed-var-ref/snapshots/3-Alignment-Error.shot b/...sics/fixtures/_error_/export-named-enum-computed-var-ref/snapshots/3-Alignment-Error.shot
diff --git a/...ges/ast-spec/src/legacy-fixtures/basics/fixtures/const-enum/snapshots/1-TSESTree-AST.shot b/...ges/ast-spec/src/legacy-fixtures/basics/fixtures/const-enum/snapshots/1-TSESTree-AST.shot
diff --git a/...st-spec/src/legacy-fixtures/basics/fixtures/const-enum/snapshots/5-AST-Alignment-AST.shot b/...st-spec/src/legacy-fixtures/basics/fixtures/const-enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/...cy-fixtures/basics/fixtures/export-declare-const-named-enum/snapshots/1-TSESTree-AST.shot b/...cy-fixtures/basics/fixtures/export-declare-const-named-enum/snapshots/1-TSESTree-AST.shot
diff --git a/...xtures/basics/fixtures/export-declare-const-named-enum/snapshots/5-AST-Alignment-AST.shot b/...xtures/basics/fixtures/export-declare-const-named-enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/...c/legacy-fixtures/basics/fixtures/export-declare-named-enum/snapshots/1-TSESTree-AST.shot b/...c/legacy-fixtures/basics/fixtures/export-declare-named-enum/snapshots/1-TSESTree-AST.shot
diff --git a/...acy-fixtures/basics/fixtures/export-declare-named-enum/snapshots/5-AST-Alignment-AST.shot b/...acy-fixtures/basics/fixtures/export-declare-named-enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/...-spec/src/legacy-fixtures/basics/fixtures/export-named-enum/snapshots/1-TSESTree-AST.shot b/...-spec/src/legacy-fixtures/basics/fixtures/export-named-enum/snapshots/1-TSESTree-AST.shot
diff --git a/.../src/legacy-fixtures/basics/fixtures/export-named-enum/snapshots/5-AST-Alignment-AST.shot b/.../src/legacy-fixtures/basics/fixtures/export-named-enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/packages/ast-spec/src/legacy-fixtures/declare/fixtures/enum/snapshots/1-TSESTree-AST.shot b/packages/ast-spec/src/legacy-fixtures/declare/fixtures/enum/snapshots/1-TSESTree-AST.shot
diff --git a/...ges/ast-spec/src/legacy-fixtures/declare/fixtures/enum/snapshots/5-AST-Alignment-AST.shot b/...ges/ast-spec/src/legacy-fixtures/declare/fixtures/enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/packages/ast-spec/tests/fixtures-with-differences-errors.shot b/packages/ast-spec/tests/fixtures-with-differences-errors.shot
diff --git a/packages/eslint-plugin/src/rules/naming-convention.ts b/packages/eslint-plugin/src/rules/naming-convention.ts
@@ -631,12 +631,10 @@ export default createRule<Options, MessageIds>({
 
       // #region interface
 
-      'TSEnumMember[computed != true]': {
-        handler: (
-          node: TSESTree.TSEnumMemberNonComputedName,
-          validator,
-        ): void => {
-          const id = node.id;
+      TSEnumMember: {
+        handler: (node: TSESTree.TSEnumMember, validator): void => {
+          // Unknown reason, can't get the correct type
+          const id = node.id as TSESTree.Identifier | TSESTree.StringLiteral;
           const modifiers = new Set<Modifiers>();
 
           if (requiresQuoting(id, compilerOptions.target)) {