-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: migrate to pnpm #11248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: migrate to pnpm #11248
Conversation
refactor: removed .yarn folder fix: changed overrides approach feat: changed references
Replacing variables
Migrate scripts to pnpm and replaced yarn reference
Replaced yarn reference with pnpm
Added rule schema types
Fixed types
Launching app pnpm
Resolved problems with babel types
docs: updated comments to reflect pnpm usage instead of yarn
…int into resolving-issues
# Conflicts: # .github/workflows/ci.yml
fix: resolve issues
fa54a51
to
42d001f
Compare
fix: resolved issues
# Conflicts: # packages/eslint-plugin/package.json # packages/type-utils/package.json # yarn.lock
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11248 +/- ##
=======================================
Coverage 90.85% 90.85%
=======================================
Files 501 501
Lines 50901 50901
Branches 8383 8383
=======================================
Hits 46248 46248
Misses 4638 4638
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
@xaos7991 thanks for sending this PR & working on it! I'm really excited about it 🎉. Since it's still got some merge conflicts & seems to be under active development, I'm going to switch it to draft (otherwise it'll keep coming up on my to-review-now queue). Whenever you're ready, go ahead and un-draft it -> we can take a look. Or holler if you need anything. 🙂 |
# Conflicts: # packages/ast-spec/package.json # yarn.lock
Hi! Thanks again for switching the PR to draft — that was a good call. I’ve resolved the latest merge conflicts, and the PR is ready for review again. Let me know if anything else is needed! |
Great! In that case, if the issue is just that |
"swizzle": "docusaurus swizzle", | ||
"typecheck": "yarn run -BT nx typecheck" | ||
"typecheck": "pnpm -w exec nx typecheck" | ||
}, | ||
"dependencies": { | ||
"@babel/runtime": "^7.24.4", | ||
"@docusaurus/core": "^3.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a mix of Docusaurus 3.2 and 3.7 now. Should probably be consistent with 3.7. Note that 3.8 is breaking and would be an upgrade if its own
PR Checklist
Overview