Skip to content

chore: migrate to pnpm #11248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 68 commits into
base: main
Choose a base branch
from

Conversation

xaos7991
Copy link
Contributor

@xaos7991 xaos7991 commented May 27, 2025

PR Checklist

Overview

xaos7991 and others added 30 commits May 18, 2025 21:32
refactor: removed .yarn folder

fix: changed overrides approach

feat: changed references
Migrate scripts to pnpm and replaced yarn reference
Resolved problems with babel types
docs: updated comments to reflect pnpm usage instead of yarn
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (9b59877) to head (7383a07).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11248   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files         501      501           
  Lines       50901    50901           
  Branches     8383     8383           
=======================================
  Hits        46248    46248           
  Misses       4638     4638           
  Partials       15       15           
Flag Coverage Δ
unittest 90.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/configs/eslintrc/all.ts 100.00% <ø> (ø)
...lugin/src/configs/eslintrc/disable-type-checked.ts 100.00% <ø> (ø)
.../configs/eslintrc/recommended-type-checked-only.ts 100.00% <ø> (ø)
...n/src/configs/eslintrc/recommended-type-checked.ts 100.00% <ø> (ø)
.../eslint-plugin/src/configs/eslintrc/recommended.ts 100.00% <ø> (ø)
...n/src/configs/eslintrc/strict-type-checked-only.ts 100.00% <ø> (ø)
...plugin/src/configs/eslintrc/strict-type-checked.ts 100.00% <ø> (ø)
...kages/eslint-plugin/src/configs/eslintrc/strict.ts 100.00% <ø> (ø)
...rc/configs/eslintrc/stylistic-type-checked-only.ts 100.00% <ø> (ø)
...gin/src/configs/eslintrc/stylistic-type-checked.ts 100.00% <ø> (ø)
... and 12 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg
Copy link
Member

@xaos7991 thanks for sending this PR & working on it! I'm really excited about it 🎉. Since it's still got some merge conflicts & seems to be under active development, I'm going to switch it to draft (otherwise it'll keep coming up on my to-review-now queue). Whenever you're ready, go ahead and un-draft it -> we can take a look. Or holler if you need anything. 🙂

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft June 9, 2025 11:32
# Conflicts:
#	packages/ast-spec/package.json
#	yarn.lock
@xaos7991 xaos7991 marked this pull request as ready for review June 9, 2025 11:49
@xaos7991
Copy link
Contributor Author

xaos7991 commented Jun 9, 2025

@xaos7991 thanks for sending this PR & working on it! I'm really excited about it 🎉. Since it's still got some merge conflicts & seems to be under active development, I'm going to switch it to draft (otherwise it'll keep coming up on my to-review-now queue). Whenever you're ready, go ahead and un-draft it -> we can take a look. Or holler if you need anything. 🙂

Hi! Thanks again for switching the PR to draft — that was a good call.

I’ve resolved the latest merge conflicts, and the PR is ready for review again.
Since the main branch is quite active, new merges tend to cause conflicts on my side — but I’m doing my best to keep up and fix them as soon as possible.

Let me know if anything else is needed!

@JoshuaKGoldberg
Copy link
Member

Great! In that case, if the issue is just that main introduces conflicts, I think it's fine to not merge in until review. I don't want our in-and-out availability to cause you a lot of extra work. Thanks for the note 🙂

"swizzle": "docusaurus swizzle",
"typecheck": "yarn run -BT nx typecheck"
"typecheck": "pnpm -w exec nx typecheck"
},
"dependencies": {
"@babel/runtime": "^7.24.4",
"@docusaurus/core": "^3.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mix of Docusaurus 3.2 and 3.7 now. Should probably be consistent with 3.7. Note that 3.8 is breaking and would be an upgrade if its own

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Migrate from yarn to pnpm
5 participants