fix(eslint-plugin): [prefer-optional-chain] ignore `check` option for most RHS of a chain #11272

nayounsang · 2025-06-05T07:34:59Z

PR Checklist

Addresses an existing open issue: fixes Bug: [prefer-optional-chain] should report case that can be converted to optional function call ?.() #11270
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Apply check option to LHSs except most RHS to fix the bug where void functions were not reported

typescript-eslint · 2025-06-05T07:35:02Z

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-06-05T07:35:05Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`dee8b4d`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/688d42f4877c41000879fdf3
😎 Deploy Preview	https://deploy-preview-11272--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 87 (🔴 down 11 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-06-05T07:36:29Z

View your CI Pipeline Execution ↗ for commit dee8b4d

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 7s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 16s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 13s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-08-01 22:55:39 UTC

codecov · 2025-06-05T07:46:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.86%. Comparing base (5b24864) to head (dee8b4d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11272   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         503      503           
  Lines       51046    51048    +2     
  Branches     8418     8416    -2     
=======================================
+ Hits        46384    46386    +2     
  Misses       4648     4648           
  Partials       14       14

Flag	Coverage Δ
unittest	`90.86% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...efer-optional-chain-utils/gatherLogicalOperands.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kirkwaiblinger

This generally looks great! Just one big question on the implementation approach we want to take. Looking forward to hearing your thoughts!

packages/eslint-plugin/src/rules/prefer-optional-chain-utils/gatherLogicalOperands.ts

…ypescript-eslint into void-optional-chain

kirkwaiblinger · 2025-07-06T23:30:04Z

This PR has the effect that the following code is flagged (with checkVoid enabled)

declare const maybeVoid: void | { x: () => { some: 'object' } };
maybeVoid && maybeVoid.x();

I'm not sure that that's what we want? I'd say instead the goal is that a void-returning function call at the end of a chain whose return value isn't used should be reported regardless of the check* options.

In other words, as far as implementation - we're not looking to include possibly-void values in checked chains except as the type of a function call at the end of the chain. It's not obvious to me that we need to create an option at all for this...

WDYT?

kirkwaiblinger · 2025-07-07T19:14:58Z

I've realized — I think this is a much more general bug. The check* options should not apply to the right hand side member of a chain. Only the left member. That is to say,

declare const x: { a: string };

// checkString: true
const y = x && x.a; // correctly reports

// checkString: false
const y = x && x.a; // (BUG) doesn't report

So, if we generally fix the logic so that the type checking only applies to the LHS of a potential chain expression x?.a, that should also automatically fix the reported bug regarding x?.a() as a special case.

nayounsang · 2025-07-12T10:50:50Z

Then, I guess we can check it except for right most. I will finish the work on void and reply.

kirkwaiblinger

I think this is moving in the right direction, but the current state of the PR seems to be mostly extraneous changes. Let's clean it up to be focused on the changes related to the bug. Thanks!

packages/eslint-plugin/tests/rules/prefer-optional-chain/prefer-optional-chain.test.ts

packages/eslint-plugin/src/rules/prefer-optional-chain-utils/gatherLogicalOperands.ts

kirkwaiblinger

(see review)

nayounsang · 2025-07-16T08:09:58Z

Oh, sorry. I misunderstood your review. Now I know what to do
I'll revert all of changes because, I changed so much and produce unnecessary codes.
Then, applying the logic to check except most RHS, I will focus on whether the issue case passes.
And if there is any problem, I will ask you. Thank you.

kirkwaiblinger · 2025-07-20T02:40:32Z

Hey @nayounsang — is this ready for another review pass? If so, we ask that you request review in the GUI so we know to take another look. If not, take your time and don't mind me! Just looked like it might be ready for another pass. Thanks!

packages/eslint-plugin/tests/rules/prefer-optional-chain/prefer-optional-chain.test.ts

…r-optional-chain.test.ts

kirkwaiblinger

Thanks!

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.32.1 | 8.39.0 | | npm | @typescript-eslint/parser | 8.32.1 | 8.39.0 | ## [v8.39.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8390-2025-08-04) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] support yield/await expressions ([#11417](typescript-eslint/typescript-eslint#11417)) - **eslint-plugin:** add no-unnecessary-type-conversion to strict-type-checked ruleset ([#11427](typescript-eslint/typescript-eslint#11427)) - update to TypeScript 5.9.2 ([#11445](typescript-eslint/typescript-eslint#11445)) - **eslint-plugin:** \[naming-convention] add enumMember PascalCase default option ([#11127](typescript-eslint/typescript-eslint#11127)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unsafe-assignment] add an `unsafeObjectPattern` message ([#11403](typescript-eslint/typescript-eslint#11403)) - **eslint-plugin:** \[prefer-optional-chain] ignore `check` option for most RHS of a chain ([#11272](typescript-eslint/typescript-eslint#11272)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - James Garbutt [@43081j](https://github.com/43081j) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Sasha Kondrashov - tao - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.38.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8380-2025-07-21) ##### 🩹 Fixes - disallow extra properties in rule options ([#11397](typescript-eslint/typescript-eslint#11397)) - **eslint-plugin:** \[consistent-generic-constructors] resolve conflict with `isolatedDeclarations` if enabled in `constructor` option ([#11351](typescript-eslint/typescript-eslint#11351)) ##### ❤️ Thank You - Andrew Kazakov [@andreww2012](https://github.com/andreww2012) - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.37.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8370-2025-07-14) ##### 🩹 Fixes - **eslint-plugin:** \[unified-signatures] fix false positives for ignoreOverloadsWithDifferentJSDoc option ([#11381](typescript-eslint/typescript-eslint#11381)) ##### ❤️ Thank You - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.36.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8360-2025-07-07) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8351-2025-06-30) ##### 🩹 Fixes - remove prettier from eslint-plugin ([#11339](typescript-eslint/typescript-eslint#11339)) ##### ❤️ Thank You - Abhijeet Singh [@cseas](https://github.com/cseas) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8350-2025-06-23) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] add checkUnknown Option ([#11128](typescript-eslint/typescript-eslint#11128)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8341-2025-06-16) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8340-2025-06-09) ##### 🩹 Fixes - **typescript-estree:** add validation to interface extends ([#11271](typescript-eslint/typescript-eslint#11271)) ##### ❤️ Thank You - Tao You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8331-2025-06-02) ##### 🩹 Fixes - exclude docs/ directory from eslint-plugin package ([#11251](typescript-eslint/typescript-eslint#11251)) ##### ❤️ Thank You - roottool You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8330-2025-05-26) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.32.1 | 8.39.0 | | npm | @typescript-eslint/parser | 8.32.1 | 8.39.0 | ## [v8.39.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8390-2025-08-04) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] support yield/await expressions ([#11417](typescript-eslint/typescript-eslint#11417)) - **eslint-plugin:** add no-unnecessary-type-conversion to strict-type-checked ruleset ([#11427](typescript-eslint/typescript-eslint#11427)) - update to TypeScript 5.9.2 ([#11445](typescript-eslint/typescript-eslint#11445)) - **eslint-plugin:** \[naming-convention] add enumMember PascalCase default option ([#11127](typescript-eslint/typescript-eslint#11127)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unsafe-assignment] add an `unsafeObjectPattern` message ([#11403](typescript-eslint/typescript-eslint#11403)) - **eslint-plugin:** \[prefer-optional-chain] ignore `check` option for most RHS of a chain ([#11272](typescript-eslint/typescript-eslint#11272)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - James Garbutt [@43081j](https://github.com/43081j) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Sasha Kondrashov - tao - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.38.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8380-2025-07-21) ##### 🩹 Fixes - disallow extra properties in rule options ([#11397](typescript-eslint/typescript-eslint#11397)) - **eslint-plugin:** \[consistent-generic-constructors] resolve conflict with `isolatedDeclarations` if enabled in `constructor` option ([#11351](typescript-eslint/typescript-eslint#11351)) ##### ❤️ Thank You - Andrew Kazakov [@andreww2012](https://github.com/andreww2012) - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.37.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8370-2025-07-14) ##### 🩹 Fixes - **eslint-plugin:** \[unified-signatures] fix false positives for ignoreOverloadsWithDifferentJSDoc option ([#11381](typescript-eslint/typescript-eslint#11381)) ##### ❤️ Thank You - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.36.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8360-2025-07-07) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8351-2025-06-30) ##### 🩹 Fixes - remove prettier from eslint-plugin ([#11339](typescript-eslint/typescript-eslint#11339)) ##### ❤️ Thank You - Abhijeet Singh [@cseas](https://github.com/cseas) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8350-2025-06-23) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] add checkUnknown Option ([#11128](typescript-eslint/typescript-eslint#11128)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8341-2025-06-16) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8340-2025-06-09) ##### 🩹 Fixes - **typescript-estree:** add validation to interface extends ([#11271](typescript-eslint/typescript-eslint#11271)) ##### ❤️ Thank You - Tao You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8331-2025-06-02) ##### 🩹 Fixes - exclude docs/ directory from eslint-plugin package ([#11251](typescript-eslint/typescript-eslint#11251)) ##### ❤️ Thank You - roottool You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8330-2025-05-26) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.32.1 | 8.39.0 | | npm | @typescript-eslint/parser | 8.32.1 | 8.39.0 | ## [v8.39.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8390-2025-08-04) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] support yield/await expressions ([#11417](typescript-eslint/typescript-eslint#11417)) - **eslint-plugin:** add no-unnecessary-type-conversion to strict-type-checked ruleset ([#11427](typescript-eslint/typescript-eslint#11427)) - update to TypeScript 5.9.2 ([#11445](typescript-eslint/typescript-eslint#11445)) - **eslint-plugin:** \[naming-convention] add enumMember PascalCase default option ([#11127](typescript-eslint/typescript-eslint#11127)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unsafe-assignment] add an `unsafeObjectPattern` message ([#11403](typescript-eslint/typescript-eslint#11403)) - **eslint-plugin:** \[prefer-optional-chain] ignore `check` option for most RHS of a chain ([#11272](typescript-eslint/typescript-eslint#11272)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - James Garbutt [@43081j](https://github.com/43081j) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Sasha Kondrashov - tao - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.38.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8380-2025-07-21) ##### 🩹 Fixes - disallow extra properties in rule options ([#11397](typescript-eslint/typescript-eslint#11397)) - **eslint-plugin:** \[consistent-generic-constructors] resolve conflict with `isolatedDeclarations` if enabled in `constructor` option ([#11351](typescript-eslint/typescript-eslint#11351)) ##### ❤️ Thank You - Andrew Kazakov [@andreww2012](https://github.com/andreww2012) - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.37.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8370-2025-07-14) ##### 🩹 Fixes - **eslint-plugin:** \[unified-signatures] fix false positives for ignoreOverloadsWithDifferentJSDoc option ([#11381](typescript-eslint/typescript-eslint#11381)) ##### ❤️ Thank You - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.36.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8360-2025-07-07) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8351-2025-06-30) ##### 🩹 Fixes - remove prettier from eslint-plugin ([#11339](typescript-eslint/typescript-eslint#11339)) ##### ❤️ Thank You - Abhijeet Singh [@cseas](https://github.com/cseas) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8350-2025-06-23) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] add checkUnknown Option ([#11128](typescript-eslint/typescript-eslint#11128)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8341-2025-06-16) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8340-2025-06-09) ##### 🩹 Fixes - **typescript-estree:** add validation to interface extends ([#11271](typescript-eslint/typescript-eslint#11271)) ##### ❤️ Thank You - Tao You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8331-2025-06-02) ##### 🩹 Fixes - exclude docs/ directory from eslint-plugin package ([#11251](typescript-eslint/typescript-eslint#11251)) ##### ❤️ Thank You - roottool You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8330-2025-05-26) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.32.1 | 8.39.0 | | npm | @typescript-eslint/parser | 8.32.1 | 8.39.0 | ## [v8.39.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8390-2025-08-04) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] support yield/await expressions ([#11417](typescript-eslint/typescript-eslint#11417)) - **eslint-plugin:** add no-unnecessary-type-conversion to strict-type-checked ruleset ([#11427](typescript-eslint/typescript-eslint#11427)) - update to TypeScript 5.9.2 ([#11445](typescript-eslint/typescript-eslint#11445)) - **eslint-plugin:** \[naming-convention] add enumMember PascalCase default option ([#11127](typescript-eslint/typescript-eslint#11127)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unsafe-assignment] add an `unsafeObjectPattern` message ([#11403](typescript-eslint/typescript-eslint#11403)) - **eslint-plugin:** \[prefer-optional-chain] ignore `check` option for most RHS of a chain ([#11272](typescript-eslint/typescript-eslint#11272)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - James Garbutt [@43081j](https://github.com/43081j) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Sasha Kondrashov - tao - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.38.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8380-2025-07-21) ##### 🩹 Fixes - disallow extra properties in rule options ([#11397](typescript-eslint/typescript-eslint#11397)) - **eslint-plugin:** \[consistent-generic-constructors] resolve conflict with `isolatedDeclarations` if enabled in `constructor` option ([#11351](typescript-eslint/typescript-eslint#11351)) ##### ❤️ Thank You - Andrew Kazakov [@andreww2012](https://github.com/andreww2012) - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.37.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8370-2025-07-14) ##### 🩹 Fixes - **eslint-plugin:** \[unified-signatures] fix false positives for ignoreOverloadsWithDifferentJSDoc option ([#11381](typescript-eslint/typescript-eslint#11381)) ##### ❤️ Thank You - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.36.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8360-2025-07-07) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8351-2025-06-30) ##### 🩹 Fixes - remove prettier from eslint-plugin ([#11339](typescript-eslint/typescript-eslint#11339)) ##### ❤️ Thank You - Abhijeet Singh [@cseas](https://github.com/cseas) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8350-2025-06-23) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] add checkUnknown Option ([#11128](typescript-eslint/typescript-eslint#11128)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8341-2025-06-16) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8340-2025-06-09) ##### 🩹 Fixes - **typescript-estree:** add validation to interface extends ([#11271](typescript-eslint/typescript-eslint#11271)) ##### ❤️ Thank You - Tao You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8331-2025-06-02) ##### 🩹 Fixes - exclude docs/ directory from eslint-plugin package ([#11251](typescript-eslint/typescript-eslint#11251)) ##### ❤️ Thank You - roottool You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8330-2025-05-26) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.32.1 | 8.39.0 | | npm | @typescript-eslint/parser | 8.32.1 | 8.39.0 | ## [v8.39.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8390-2025-08-04) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] support yield/await expressions ([#11417](typescript-eslint/typescript-eslint#11417)) - **eslint-plugin:** add no-unnecessary-type-conversion to strict-type-checked ruleset ([#11427](typescript-eslint/typescript-eslint#11427)) - update to TypeScript 5.9.2 ([#11445](typescript-eslint/typescript-eslint#11445)) - **eslint-plugin:** \[naming-convention] add enumMember PascalCase default option ([#11127](typescript-eslint/typescript-eslint#11127)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unsafe-assignment] add an `unsafeObjectPattern` message ([#11403](typescript-eslint/typescript-eslint#11403)) - **eslint-plugin:** \[prefer-optional-chain] ignore `check` option for most RHS of a chain ([#11272](typescript-eslint/typescript-eslint#11272)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - James Garbutt [@43081j](https://github.com/43081j) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Sasha Kondrashov - tao - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.38.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8380-2025-07-21) ##### 🩹 Fixes - disallow extra properties in rule options ([#11397](typescript-eslint/typescript-eslint#11397)) - **eslint-plugin:** \[consistent-generic-constructors] resolve conflict with `isolatedDeclarations` if enabled in `constructor` option ([#11351](typescript-eslint/typescript-eslint#11351)) ##### ❤️ Thank You - Andrew Kazakov [@andreww2012](https://github.com/andreww2012) - Younsang Na [@nayounsang](https://github.com/nayounsang) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.37.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8370-2025-07-14) ##### 🩹 Fixes - **eslint-plugin:** \[unified-signatures] fix false positives for ignoreOverloadsWithDifferentJSDoc option ([#11381](typescript-eslint/typescript-eslint#11381)) ##### ❤️ Thank You - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.36.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8360-2025-07-07) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8351-2025-06-30) ##### 🩹 Fixes - remove prettier from eslint-plugin ([#11339](typescript-eslint/typescript-eslint#11339)) ##### ❤️ Thank You - Abhijeet Singh [@cseas](https://github.com/cseas) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.35.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8350-2025-06-23) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] add checkUnknown Option ([#11128](typescript-eslint/typescript-eslint#11128)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8341-2025-06-16) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.34.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8340-2025-06-09) ##### 🩹 Fixes - **typescript-estree:** add validation to interface extends ([#11271](typescript-eslint/typescript-eslint#11271)) ##### ❤️ Thank You - Tao You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8331-2025-06-02) ##### 🩹 Fixes - exclude docs/ directory from eslint-plugin package ([#11251](typescript-eslint/typescript-eslint#11251)) ##### ❤️ Thank You - roottool You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.33.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8330-2025-05-26) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

nayounsang added 4 commits June 5, 2025 16:11

feat: add check void option

aec9ef5

test: add test case for check void

e35a6f2

feat: check void type

eacc622

chore: add snapshot

88decc1

nayounsang changed the title ~~fix(prefer-optional-chain): should report case that can be converted to optional function call ?.()~~ fix(eslint-plugin): should report case that can be converted to optional function call ?.() when using perfer-optional-chain Jun 5, 2025

nayounsang marked this pull request as draft June 5, 2025 07:38

docs: add checkvoid section

4171c5e

nayounsang changed the title ~~fix(eslint-plugin): should report case that can be converted to optional function call ?.() when using perfer-optional-chain~~ fix(eslint-plugin): should report case that can be converted to optional void function call ?.() when using perfer-optional-chain Jun 5, 2025

chore: update snapshot

791461b

nayounsang marked this pull request as ready for review June 5, 2025 08:11

kirkwaiblinger changed the title ~~fix(eslint-plugin): should report case that can be converted to optional void function call ?.() when using perfer-optional-chain~~ fix(eslint-plugin): [prefer-optional-chain] should report case that can be converted to optional void function call ?.() Jun 6, 2025

kirkwaiblinger changed the title ~~fix(eslint-plugin): [prefer-optional-chain] should report case that can be converted to optional void function call ?.()~~ fix(eslint-plugin): [prefer-optional-chain] should report case that can be converted to optional void function call ?.() Jun 6, 2025

kirkwaiblinger reviewed Jun 6, 2025

View reviewed changes

packages/eslint-plugin/src/rules/prefer-optional-chain-utils/gatherLogicalOperands.ts Outdated Show resolved Hide resolved

kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Jun 6, 2025

nayounsang and others added 5 commits June 7, 2025 17:22

refactor: inject option based on flagsToExcludeFromCheck

b3d2a4f

test: add test for checkVoid = false

656ec50

Merge branch 'main' into void-optional-chain

3ea00d0

Merge branch 'void-optional-chain' of https://github.com/nayounsang/t…

5e7fec4

…ypescript-eslint into void-optional-chain

test: add tc for all checks are excluded but invaild

4b92ad4

Merge branch 'main' into void-optional-chain

01f6313

nayounsang added 3 commits July 12, 2025 21:40

test: add test cases

b3bf6b7

fix: ignore isValidFalseBooleanCheckType if there is no more op

b0adaa8

feat: remove checkVoid option

2559e54

fix: reupdate snapshot

1ef4c51

kirkwaiblinger reviewed Jul 14, 2025

View reviewed changes

kirkwaiblinger requested changes Jul 14, 2025

View reviewed changes

kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Jul 14, 2025

nayounsang and others added 5 commits July 16, 2025 17:23

Merge branch 'main' into void-optional-chain

d0b2c6b

chore: revert gatherLogicalOperands.ts

87107cd

chore: revert perfer-optional-chain.test.ts

cba0f37

fix: ignore isValidFalseBooleanCheckType if there is no more op

433e6d4

test: add test case

baf82db

nayounsang changed the title ~~fix(eslint-plugin): [prefer-optional-chain] should report case that can be converted to optional void function call ?.()~~ fix(eslint-plugin): [prefer-optional-chain] ignore check option for most RHS of a chain Jul 16, 2025

nayounsang requested a review from kirkwaiblinger July 20, 2025 10:40

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 20, 2025

kirkwaiblinger reviewed Jul 21, 2025

View reviewed changes

packages/eslint-plugin/tests/rules/prefer-optional-chain/prefer-optional-chain.test.ts Outdated Show resolved Hide resolved

Update packages/eslint-plugin/tests/rules/prefer-optional-chain/prefe…

6095671

…r-optional-chain.test.ts

kirkwaiblinger previously approved these changes Jul 21, 2025

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 21, 2025

Update prefer-optional-chain.test.ts

6fafc22

kirkwaiblinger dismissed their stale review via 6fafc22 July 21, 2025 07:51

kirkwaiblinger approved these changes Jul 21, 2025

View reviewed changes

kirkwaiblinger enabled auto-merge (squash) August 1, 2025 22:22

Merge branch 'main' into void-optional-chain

dee8b4d

kirkwaiblinger merged commit 757f9ee into typescript-eslint:main Aug 1, 2025
61 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2025

Uh oh!

fix(eslint-plugin): [prefer-optional-chain] ignore check option for most RHS of a chain #11272

fix(eslint-plugin): [prefer-optional-chain] ignore check option for most RHS of a chain #11272

Conversation

nayounsang commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Jun 5, 2025

Uh oh!

netlify bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kirkwaiblinger commented Jul 6, 2025

Uh oh!

kirkwaiblinger commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nayounsang commented Jul 12, 2025

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

nayounsang commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kirkwaiblinger commented Jul 20, 2025

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fix(eslint-plugin): [prefer-optional-chain] ignore `check` option for most RHS of a chain #11272

fix(eslint-plugin): [prefer-optional-chain] ignore `check` option for most RHS of a chain #11272

nayounsang commented Jun 5, 2025 •

edited

Loading

netlify bot commented Jun 5, 2025 •

edited

Loading

nx-cloud bot commented Jun 5, 2025 •

edited

Loading

codecov bot commented Jun 5, 2025 •

edited

Loading

kirkwaiblinger commented Jul 7, 2025 •

edited

Loading

nayounsang commented Jul 16, 2025 •

edited

Loading