chore(eslint-plugin): switch auto-generated test cases to hand-written in no-inferrable-types.test.ts #11275
Conversation
|
Thanks for the PR, @Vinccool96! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 0385582.
☁️ Nx Cloud last updated this comment at |
| "const a = new RegExp('a');", | ||
| // Testing with double quotes | ||
| // eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting | ||
| 'const a = "str";', |
There was a problem hiding this comment.
Could be removed, since the only change with the one below is that it's using double quotes
| { | ||
| // Testing with double quotes | ||
| // eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting | ||
| code: 'const a: string = "str";', |
There was a problem hiding this comment.
Could be removed, since the only change with the one below is that it's using double quotes
There was a problem hiding this comment.
Great work! This looks like it was probably very tedious, thanks for slogging through it.
+1 from me on removing the likely unnecessary tests. That's a big value prop for this effort IMO. Do you want to do that before merge @Vinccool96?
|
Yeah, I'll remove them |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11275 +/- ##
=======================================
Coverage 90.85% 90.85%
=======================================
Files 501 501
Lines 50901 50901
Branches 8383 8383
=======================================
Hits 46248 46248
Misses 4638 4638
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
PR Checklist
Overview