feat(typescript-estree): infer tsconfigRootDir from call stack #11370

JoshuaKGoldberg · 2025-07-03T18:55:54Z

PR Checklist

Addresses an existing open issue: fixes Enhancement: Default tsconfigRootDir to the running flat config's directory if available #10841
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Adds a trio of logical pieces:

candidateTSConfigRootDirs: stores candidate root directories inside typescript-estree, exposed via add*, clear*, and get* functions
- The get*, getInferredTSConfigRootDir, will throw an error if multiple candidates have been populated. It's only called by createParseSettings if no tsconfigRootDir was explicitly provided.
getTSConfigRootDirFromStack: given a call stack, gets the candidate directory hosting an ESLint config file -- if it can be found
createConfigsGetters: wraps the configs in typescript-eslint with getters that pass the result of getRootDirFromStack to candidateTSConfigRootDirs

The result is that using any configs like tseslint.configs.recommendedTypeChecked will attempt to populate a candidate tsconfigRootDir for parse settings.

💖

typescript-eslint · 2025-07-03T18:55:58Z

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-07-03T18:55:58Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`718b881`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/686eeed8b40e270008afc7d6
😎 Deploy Preview	https://deploy-preview-11370--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 86 (🔴 down 3 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

packages/typescript-eslint/src/index.ts

nx-cloud · 2025-07-03T18:57:11Z

View your CI Pipeline Execution ↗ for commit 718b881

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 15s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 11s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 12s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	20s	View ↗
`nx run integration-tests:test`	✅ Succeeded	7s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-07-09 22:47:39 UTC

packages/typescript-eslint/tests/getRootDirFromStack.test.ts

packages/typescript-eslint/src/getRootDirFromStack.ts

codecov · 2025-07-04T12:57:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (16c344e) to head (718b881).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11370   +/-   ##
=======================================
  Coverage   90.85%   90.86%           
=======================================
  Files         501      503    +2     
  Lines       50987    51028   +41     
  Branches     8410     8421   +11     
=======================================
+ Hits        46324    46365   +41     
  Misses       4648     4648           
  Partials       15       15

Flag	Coverage Δ
unittest	`90.86% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...pescript-eslint/src/getTSConfigRootDirFromStack.ts	`100.00% <100.00%> (ø)`
packages/typescript-estree/src/clear-caches.ts	`100.00% <100.00%> (ø)`
...ree/src/parseSettings/candidateTSConfigRootDirs.ts	`100.00% <100.00%> (ø)`
...pt-estree/src/parseSettings/createParseSettings.ts	`92.18% <100.00%> (+0.04%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bradzacher · 2025-07-09T13:48:40Z

packages/typescript-eslint/src/index.ts

@@ -3,8 +3,10 @@ import type { TSESLint } from '@typescript-eslint/utils';

 import pluginBase from '@typescript-eslint/eslint-plugin';
 import rawPlugin from '@typescript-eslint/eslint-plugin/use-at-your-own-risk/raw-plugin';
+import { addCandidateTSConfigRootDir } from '@typescript-eslint/typescript-estree';


this adds dependency on a transitive dep -- which will break consumers.
the dep needs to be listed in the package.json

there's something with our lint config -- there should be like import/no-extraneous-deps or something that's covering this.

I think import-x would have caught this 😄

packages/typescript-estree/src/parseSettings/candidateTSConfigRootDirs.ts

feat(typescript-estree): infer tsconfigRootDir from call stack

f368171

JoshuaKGoldberg commented Jul 3, 2025

View reviewed changes

packages/typescript-eslint/src/index.ts Show resolved Hide resolved

JoshuaKGoldberg commented Jul 3, 2025

View reviewed changes

packages/typescript-eslint/tests/getRootDirFromStack.test.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg commented Jul 3, 2025

View reviewed changes

packages/typescript-eslint/src/getRootDirFromStack.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added 2 commits July 3, 2025 15:41

rename

88edcc3

Adjust for Windows

c42ce4c

JoshuaKGoldberg added 8 commits July 4, 2025 09:02

lint

2856485

Merge branch 'main' into infer-tsconfigrootdir-candidates

dc37428

Unit tested the candidate detection

5474282

mv

4d7aae9

Merge branch 'main' into infer-tsconfigrootdir-candidates

cecf62e

rm packages/website/data/recent-blog-posts.json

3a94f40

chore: have website lint depend on its build

5718708

Merge branch 'main' into infer-tsconfigrootdir-candidates

53cbcb1

JoshuaKGoldberg marked this pull request as ready for review July 4, 2025 14:11

JoshuaKGoldberg requested a review from a team July 4, 2025 14:11

Add file:/// testing back

9266c7d

bradzacher previously approved these changes Jul 9, 2025

View reviewed changes

JoshuaKGoldberg dismissed bradzacher’s stale review via 7c0a5fc July 9, 2025 21:26

Add doc link

7c0a5fc

JoshuaKGoldberg requested a review from kirkwaiblinger July 9, 2025 21:27

JoshuaKGoldberg added 4 commits July 9, 2025 17:27

dep

13879b7

Merge branch 'main'

5ee0eaf

Heh, wrong paackage

37d822b

yarn test -u

718b881

JoshuaKGoldberg requested a review from bradzacher July 9, 2025 22:41

bradzacher approved these changes Jul 10, 2025

View reviewed changes

JoshuaKGoldberg merged commit 7126c3a into typescript-eslint:main Jul 14, 2025
64 checks passed

JoshuaKGoldberg deleted the infer-tsconfigrootdir-candidates branch July 14, 2025 11:37

matthew-plusprogramming mentioned this pull request Jul 15, 2025

Bug: Inferred parserOptions.tsconfigRootDir concatenates incorrectly when path includes space #11398

Open

4 tasks

joshbwlng mentioned this pull request Jul 15, 2025

Specify tsconfigRootDir so local configs are used balena-io-modules/node-balena-lint#131

Merged

chabb mentioned this pull request Jul 15, 2025

Bug: <short description of the issue> #11399

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(typescript-estree): infer tsconfigRootDir from call stack #11370

feat(typescript-estree): infer tsconfigRootDir from call stack #11370

JoshuaKGoldberg commented Jul 3, 2025 •

edited

Loading

Uh oh!

typescript-eslint bot commented Jul 3, 2025

Uh oh!

netlify bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

nx-cloud bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

bradzacher Jul 9, 2025

Uh oh!

JoshuaKGoldberg Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(typescript-estree): infer tsconfigRootDir from call stack #11370

feat(typescript-estree): infer tsconfigRootDir from call stack #11370

Conversation

JoshuaKGoldberg commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Jul 3, 2025

Uh oh!

netlify bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

Uh oh!

nx-cloud bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bradzacher Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg commented Jul 3, 2025 •

edited

Loading

netlify bot commented Jul 3, 2025 •

edited

Loading

nx-cloud bot commented Jul 3, 2025 •

edited

Loading

codecov bot commented Jul 4, 2025 •

edited

Loading